Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add support for Javascript Typed Arrays #40

Closed
GoogleCodeExporter opened this issue Sep 11, 2015 · 5 comments
Closed

Add support for Javascript Typed Arrays #40

GoogleCodeExporter opened this issue Sep 11, 2015 · 5 comments

Comments

@GoogleCodeExporter
Copy link

Glancing over the source I've noticed that crypto-JS does not seem to support 
Javascript typed Arrays 
(https://developer.mozilla.org/en/JavaScript_typed_arrays)

Adding support for this would probably speed up the library a bit.

What steps will reproduce the problem?
1.
2.
3.

What is the expected output? What do you see instead?


What version of the product are you using? On what operating system?


Please provide any additional information below.

Original issue reported on code.google.com by oli...@weichhold.com on 15 Jun 2012 at 7:01

@GoogleCodeExporter
Copy link
Author

Hi, Oliver. Unfortunately the typed arrays are not cross-browser compatible. 
And in fact the browser most in need of a speed boost is the same browser that 
doesn't support the typed arrays.

Original comment by Jeff.Mott.OR on 15 Jun 2012 at 7:28

@GoogleCodeExporter
Copy link
Author

Hi Jeff

Sure they are not universally available but since you already got the 
abstraction for WordArray.create it should be possible to leverage typed arrays 
when available.

Original comment by oli...@weichhold.com on 15 Jun 2012 at 8:00

@GoogleCodeExporter
Copy link
Author

Original comment by Jeff.Mott.OR on 21 Jun 2012 at 9:17

  • Added labels: Type-Enhancement
  • Removed labels: Type-Defect

@GoogleCodeExporter
Copy link
Author

Issue 46 has been merged into this issue.

Original comment by Jeff.Mott.OR on 22 Aug 2012 at 10:01

@GoogleCodeExporter
Copy link
Author

The latest release includes the ability to create WordArrays from typed arrays. 
You'll need to include an additional component -- lib-typedarrays.

<script 
src="http://crypto-js.googlecode.com/svn/tags/3.1/build/components/core.js"></sc
ript>
<script 
src="http://crypto-js.googlecode.com/svn/tags/3.1/build/components/lib-typedarra
ys.js"></script>
<script>
    var wordArray = CryptoJS.lib.WordArray.create(uint8View);
</script>

You can create a WordArray from any of the typed array views -- Int8Array, 
Int16Array, etc. -- or from an ArrayBuffer, or from a DataView.

This is likely as far as this library will go with typed arrays until they 
become more cross browser compatible.

Original comment by Jeff.Mott.OR on 7 Jan 2013 at 2:00

  • Changed state: Fixed

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

1 participant