Skip to content
This repository has been archived by the owner on Jan 6, 2020. It is now read-only.

Initial SafeCoin implementation. #60

Merged
merged 1 commit into from May 29, 2015
Merged

Initial SafeCoin implementation. #60

merged 1 commit into from May 29, 2015

Conversation

ghost
Copy link

@ghost ghost commented May 29, 2015

Review on Reviewable

@dirvine
Copy link
Contributor

dirvine commented May 29, 2015

Review status: all files reviewed, 1 unresolved discussion, some commit checks pending.
Reviewed files:

  • src/coin/mod.rs @ r1
  • src/coin/safecoin.rs @ r1
  • src/lib.rs @ r1

src/lib.rs, line 47 [r1] (raw file):
In next iter I would think about renaming this to safecoin, to allow space for other coins later.


Comments from the review on Reviewable.io

dirvine added a commit that referenced this pull request May 29, 2015
Initial SafeCoin implementation.
@dirvine dirvine merged commit 3aac244 into maidsafe-archive:master May 29, 2015
@coveralls
Copy link

Coverage Status

Coverage decreased (-0.47%) to 92.44% when pulling e71daa7 on s-brian:MAID-1036 into a955ad8 on maidsafe:master.

@ghost
Copy link
Author

ghost commented May 29, 2015

Review status: all files reviewed, 1 unresolved discussion, some commit checks failed.


src/lib.rs, line 47 [r1] (raw file):
Sure, it'll need a few more tests as well as additional functionality. I can include additional tests anytime though.


Comments from the review on Reviewable.io

@ghost ghost deleted the MAID-1036 branch May 29, 2015 22:09
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants