This repository has been archived by the owner on Jan 6, 2020. It is now read-only.
fix/v0.5: resolve dns invalid file path error #172
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Resolves file stream issue in dns getFile api. Refactored response handler and updated the responses to be send in json format through the handler. DNS and NFS updated to use ResponseHandler from server/utils.js
…n error messages Refactored auth.js to use responsehandler for sending validation error messages
Updated the error code to 404 for not found or invalid file path
|
r? @ustulation (maidsafe_highfive has picked a reviewer for you, use r? to override) |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Resolves file stream issue in dns getFile api. Refactored response handler and updated the responses to be send in json format through the handler.
DNS and NFS updated to use ResponseHandler from server/utils.js
Test cases updated
This change is