This repository has been archived by the owner on Jan 6, 2020. It is now read-only.
refactor/stop_proxy: stop proxy while logout #210
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
stop proxy until unauthorised client is created
|
r? @ustulation (maidsafe_highfive has picked a reviewer for you, use r? to override) |
|
I am not sure this is a good idea. The proxy should allow browsing all the time whether logged in or not. |
Remove toast message for proxy started event
|
@dirvine it should be enabled. its just stopped for the duration when there is no routing client object(gap between destroying the registered client and creating a new unregistered client and getting it bootstrapped). The restart portion is not in this PR cos it's already doing whats expected based. |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
stop proxy until unauthorised client is created
This change is