Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Bench tests give out of bounds error: #39

Closed
steveklabnik opened this issue Apr 10, 2015 · 9 comments
Closed

Bench tests give out of bounds error: #39

steveklabnik opened this issue Apr 10, 2015 · 9 comments

Comments

@steveklabnik
Copy link
Contributor

$ cargo bench
     Running target/release/lib-a1c7f0b70117a838

running 5 tests
test bench_write_then_read_a_200B ... bench:     11708 ns/iter (+/- 532) = 34 MB/s
test bench_write_then_read_b_1KB  ... bench:     42412 ns/iter (+/- 3723) = 48 MB/s
test bench_write_then_read_c_1MB  ... thread '<main>' panicked at 'index out of bounds: the len is 1048576 but the index is 1048576', /home/rustbuild/src/rust-buildbot/slave/nightly-dist-rustc-linux/build/src/libcollections/vec.rs:1356

This is on Debian.

@dirvine
Copy link
Member

dirvine commented Apr 10, 2015

Interesting what rustc --version is this with ?

@steveklabnik
Copy link
Contributor Author

rustc 1.0.0-nightly (6b95d8bed 2015-04-09) (built 2015-04-10)

@dirvine
Copy link
Member

dirvine commented Apr 10, 2015

yip confirmed with rustc 1.0.0-nightly (d9146bf8b 2015-04-07) (built 2015-04-08)
Happy you ignore that one for now and I will take a peek and push a fix.

@dirvine
Copy link
Member

dirvine commented Apr 10, 2015

Yes a bug introduced in the read method, I have commented out that for now to let you check out bench and will commit a fix as soon as I figure out the issue. One of the guys working on it now. (frantic pace week :-) )

@dirvine
Copy link
Member

dirvine commented Apr 10, 2015

weird, bench is OK till rustc --version rustc 1.0.0-nightly (be9bd7c93 2015-04-05) (built 2015-04-06)

@benjaminbollen
Copy link
Contributor

I updated from rustc from build 2015-04-06 to nightly 2015-04-10 and again benchmarks and tests pass. Does it succeed for you on the latest nigthly?

@steveklabnik
Copy link
Contributor Author

(frantic pace week :-) )

Oh don't I know that feeling

@dirvine
Copy link
Member

dirvine commented Apr 10, 2015

I bet! All good though

@Fraser999
Copy link
Contributor

Benchmark tests all pass with current code.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

4 participants