Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Upgrade nbconvert above 6.0.7 #493

Closed
MLecardonnel opened this issue Sep 19, 2023 · 0 comments · Fixed by #494
Closed

Upgrade nbconvert above 6.0.7 #493

MLecardonnel opened this issue Sep 19, 2023 · 0 comments · Fixed by #494

Comments

@MLecardonnel
Copy link
Collaborator

MLecardonnel commented Sep 19, 2023 •
edited

I had an issue trying to generate a shapash report because of nbconvert and an incompatibility with Jinja2.
importlib.import_module("nbconvert") in

shapash/shapash/report/__init__.py

Line 14 in 929f8b2

def check_report_requirements():
fails with a version 3.1.2 of Jinja2.

I upgraded nbconvert>=6.0.7 version like it is done in requirements.dev.txt and it works.

shapash/setup.py

Line 44 in 929f8b2

'nbconvert==6.0.7',

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

update shapash report require ThomasBouche/shapash
1 participant
@MLecardonnel