Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Always returns :ok? #13

Closed
houshuang opened this issue Jul 11, 2015 · 2 comments
Closed

Always returns :ok? #13

houshuang opened this issue Jul 11, 2015 · 2 comments

Comments

@houshuang
Copy link
Contributor

This is a great library, and I'm using it to send hundreds of personalized emails per day through Amazon SES. However, it seems that it always returns :ok, no matter if it was successful or not - even on completely made up domains (I'm using the external_smtp module).

This becomes especially important because Amazon has some rate limiting, and I should be able to retry if a mail fails, etc.

(Actually do you know of any library for sending large amounts of emails which handle throttling, retrying, etc? Would be incredibly useful - but knowing if a delivery succeeded or not is the first step).

thanks!

@kamilc
Copy link
Collaborator

kamilc commented Aug 3, 2015

Yah, it seems that we should incorporate some success/error checking. Thank you for the suggestion. I'm not aware of any high level email sending libraries but it seems that the behaviors you're after are pretty general and could be encapsulated in a library.

@kamilc
Copy link
Collaborator

kamilc commented Sep 21, 2015

I've just merged in the pull request that drops the Async usage from sending. The function call now returns the underlying execution info from gen_smtp. I'm closing the ticket.

@kamilc kamilc closed this as completed Sep 21, 2015
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants