Fix lexer.errInvalidToken panic #184
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
alexej-v
force-pushed
the
errInvalidToken_panic_fix
branch
2 times, most recently
from
78c5fe0
to
f8c45dd
Compare
alexej-v
force-pushed
the
errInvalidToken_panic_fix
branch
from
f8c45dd
to
30bdb17
Compare
vstarodub
reviewed
Jul 26, 2018
jlexer/lexer.go
Outdated
| isValid, hasEscapes, length := findStringLen(data) | ||
| if !isValid { | ||
| r.pos += length | ||
| r.errParse("missing trailing string literal") |
There was a problem hiding this comment.
"unterminated string literal", or "missing trailing quote char". A literal is the whole string with opening/ending quote chars.
jlexer/lexer_test.go
Outdated
| for _, test := range []struct { | ||
| data []byte | ||
| }{ | ||
| {data: []byte(`"sting without trailing literal`)}, |
There was a problem hiding this comment.
same here, "... trailing quote"
jlexer/lexer_test.go
Outdated
| l := Lexer{Data: test.data} | ||
| l.fetchString() | ||
| if l.pos > len(l.Data) { | ||
| t.Errorf("pos should not be greater than length of Data") |
There was a problem hiding this comment.
Please indicate what test case failed, e.g.:
t.Errorf("fetchString(%s): pos should not be greater than length of Data", test.data)
Same goes for the error below.
vstarodub
approved these changes
Jul 27, 2018
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes panic during processing jlexer.Data with the same length and capacity