Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix handling of anon structs with embedded structs and fields #339

Open
wants to merge 2 commits into
base: master
Choose a base branch
from
Open

Fix handling of anon structs with embedded structs and fields #339

wants to merge 2 commits into from

Commits on May 10, 2021

  1. Fix Makefile lines with leading space instead of tab

    @autarch
    autarch committed May 10, 2021
    Configuration menu
    Copy the full SHA
    65096d9 View commit details
    Browse the repository at this point in the history

  2. Fix bug in handling on anon structs which embed other structs 

    If the anon struct embeds another struct _and_ contains fields of its own,
there were cases where the generated code would ignore the anon struct's own
fields.

This happened because when checking if the anon struct implements a marshaling
interface, the reflect package returns true if the anon struct's _embedded
struct_ implements that interface. But using that interface means that the
other fields in the anon struct are ignored.
    @autarch
    autarch committed May 10, 2021
    Configuration menu
    Copy the full SHA
    6ea728d View commit details
    Browse the repository at this point in the history