Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add remove functionality in the To Do List Project #2

Merged
merged 8 commits into from
May 12, 2023
Merged

Conversation

mailsg
Copy link
Owner

@mailsg mailsg commented May 10, 2023

Hi,

This PR demonstrates the implementation of JavaScript ES6 modular practices to Add and Remove tasks from a To Do List App as well as the use of Webpack to bundle JavaScript.

Below are the contents of the implementation :-

  1. Removed all the hard coded items from the tasks array.
  2. Created JavaScript files for new functionality.
  3. Implemented function for adding a new task (add a new element to the array).
  4. Implemented function for deleting a task (remove an element from the array).
  5. Implemented function for editing task descriptions.
  6. New tasks have the property completed set to false and the property index set to the value of the new array length.
  7. Deleting a task updates all remaining items' indexes, so they represent the current list order and are unique.
  8. All changes to the To Do List are saved in local storage.

Kindly provide feedback for the above implementations.

Thanks.

Copy link

@pinkmoon25 pinkmoon25 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hi @mailsg ,

Your project is complete! There is nothing else to say other than... it's time to merge it :shipit:
Congratulations! 🎉

Highlights

Linter checks ✔️
github flow ✔️
Add and Remove ✔️
Editing tasks ✔️

Optional suggestions

Every comment with the [OPTIONAL] prefix won't stop the approval of this PR. However, I strongly recommend you to take them into account as they can make your code better. Some of them were simply missed by the previous reviewer and addressing them will really improve your application.

Cheers and Happy coding!👏👏👏

Feel free to leave any questions or comments in the PR thread if something is not 100% clear.
Please, remember to tag me in your question so I can receive the notification.


As described in the Code reviews limits policy you have a limited number of reviews per project (check the exact number in your Dashboard). If you think that the code review was not fair, you can request a second opinion using this form.

Comment on lines +70 to +74
form.addEventListener('submit', () => {
addTask(simpleTodoTasks, input.value);
populateTask(simpleTodoTasks);
input.value = '';
});

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

  • [OPTIONAL] Good job, everything is working well, I would suggest adding a check for empty values before adding the tasks, as currently user can just hit enter and add a task without any text or detail for the task 👍

@mailsg mailsg merged commit e30ef1c into main May 12, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants