Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Feature: Name mixins and other exports of this addon #1357

Closed
pichfl opened this issue Jun 1, 2017 · 5 comments
Closed

Feature: Name mixins and other exports of this addon #1357

pichfl opened this issue Jun 1, 2017 · 5 comments

Comments

@pichfl
Copy link
Contributor

pichfl commented Jun 1, 2017

I work on large projects and more than often I find myself wading through a whole bunch of UnknownMixin and similar objects inside of Ember Inspector.

We recently discovered that Ember Inspector reads the [Ember.NAME_KEY] property of each Ember Object to display a proper name.

Therefore I propose to add this property to all mixins and objects exported by this addon, making the object stack a bit easier to read.

If this sounds interesting, I'll supply a pull request for this. 🙂

@marcoow
Copy link
Member

marcoow commented Jun 1, 2017

Seems like a worthwhile addition. I'm not sure Ember.NAME_KEY is public or there's a public way of accessing it though?

@marcoow
Copy link
Member

marcoow commented Jun 1, 2017

guess it's "intimate" API then 😉

So yeah, PR would be 👍

@pichfl
Copy link
Contributor Author

pichfl commented Jun 1, 2017

After talking to @rwjblue on Slack I'd consider wrapping these calls with the DEBUG flag described here: https://github.com/babel/ember-cli-babel#general-purpose-env-flags (and in his blog post here), making this only available in development. (Or maybe just a stripped down version described in this gist)

pichfl pushed a commit to pichfl/ember-simple-auth that referenced this issue Jun 7, 2017
Do not merge this yet, tests are missing.

Re mainmatter#1357
@pichfl pichfl closed this as completed Jun 8, 2017
pichfl pushed a commit to pichfl/ember-simple-auth that referenced this issue Aug 4, 2017
Added names to mixins for Ember Inspector

Re mainmatter#1357
pichfl pushed a commit to pichfl/ember-simple-auth that referenced this issue Aug 4, 2017
@marcoow
Copy link
Member

marcoow commented Dec 19, 2017

This should actually be fixed in the Ember Inspector - see ember-cli/ember-rfc176-data#12 (comment)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants