Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

add basic crd docs #572

Merged
merged 2 commits into from
Dec 2, 2020
Merged

add basic crd docs #572

merged 2 commits into from
Dec 2, 2020

Conversation

rcernich
Copy link
Contributor

@rcernich rcernich commented Oct 1, 2020

Signed-off-by: rcernich rcernich@redhat.com

I still need to organize the output and remove the generated JSON schema. Should probably also edit the field comments to get better doc output. And filter out basic types like TypeMeta and ObjectMeta.

Copy link
Contributor

@dgn dgn left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

good stuff

@dgn
Copy link
Contributor

dgn commented Oct 20, 2020

Maybe we can add something to maistra.github.io that imports these

@rcernich
Copy link
Contributor Author

Yeah, I think @brian-avery was going to look into possibly doing something.

Signed-off-by: rcernich <rcernich@redhat.com>
@brian-avery
Copy link
Contributor

@Mergifyio refresh

@mergify
Copy link
Contributor

mergify bot commented Dec 2, 2020

Command refresh: success

Pull request refreshed

@mergify mergify bot removed the ready to merge label Dec 2, 2020
@mergify mergify bot merged commit ba37d5c into maistra:maistra-2.0 Dec 2, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants