Improve flexibility of geordi test #220
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
brunosedler
force-pushed
the
bs/improve-flexibility-of-geordi-tests
branch
from
ab6b31b
to
02a5a98
Compare
codener
reviewed
Jun 14, 2024
There was a problem hiding this comment.
Looks good so far! However, two requirements from the original issue #216 are missing:
- Remember to update the LONGDESC as well.
- It would be nice to have the results summary of both test commands printed last. However, I don't know how this could work. So please at least make sure that the RSpec status is printed after cucumber ran. Like "if rspec_ran and cucumber_ran then print RSpec success/failure" after the invocation of cucumber.
Or would RSpec already fail and Cucumber not even be executed?
I assume if rspec fails, cucumber would not even be executed. That's the current behavior when all specs and features are running, and the code would be similar in the case when we run selected tests with rspec and cucumber. Maybe we could rescue the rspec-call if that feature is important to you 🤔 |
codener
approved these changes
Jul 1, 2024
brunosedler
force-pushed
the
bs/improve-flexibility-of-geordi-tests
branch
from
53a8291
to
1b6acb5
Compare
brunosedler
force-pushed
the
bs/improve-flexibility-of-geordi-tests
branch
from
1b6acb5
to
5995068
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes #216