Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add support for parallel_tests to "geordi unit" #222

Merged
merged 2 commits into from
Aug 2, 2024
Merged

Add support for parallel_tests to "geordi unit" #222

merged 2 commits into from
Aug 2, 2024

Conversation

martinschaflitzl1
Copy link
Collaborator

This will check and use parallel_tests for geordi unit.

I also upgraded nokogiri, as the old version used would not install on my Ubuntu 22.04 installation.

@martinschaflitzl1 martinschaflitzl1 marked this pull request as ready for review July 30, 2024 15:58
codener
codener approved these changes Aug 2, 2024
View reviewed changes
Copy link
Member

@codener codener left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I cannot judge whether this change will work in all usage scenarios. I don't use geordi unit myself. But by itself, it looks all good.

Please process the remarks, then merge.

features/unit.feature Outdated Show resolved Hide resolved
lib/geordi/commands/unit.rb Outdated Show resolved Hide resolved
@martinschaflitzl1 martinschaflitzl1 force-pushed the ms/use_parallel_tests_for_unit_tests branch from 8e9af38 to 21a7760 Compare August 2, 2024 08:16
@martinschaflitzl1 martinschaflitzl1 merged commit 56975fe into master Aug 2, 2024
3 checks passed
@martinschaflitzl1 martinschaflitzl1 deleted the ms/use_parallel_tests_for_unit_tests branch August 2, 2024 08:19
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@codener codener codener approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@martinschaflitzl1 @codener