Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Hard dependency on librosa because of package level import #62

Closed
chiragjn opened this issue Nov 16, 2019 · 2 comments
Closed

Hard dependency on librosa because of package level import #62

chiragjn opened this issue Nov 16, 2019 · 2 comments
Labels
bug Something isn't working

Comments

@chiragjn
Copy link
Contributor

Minor issue, but a hard dependency on librosa still exists but is not mentioned in dependencies

|     import nlpaug.augmenter.char as nac
|   File "/usr/local/lib/python3.6/site-packages/nlpaug/__init__.py", line 2, in <module>
|     from nlpaug.base_augmenter import *
|   File "/usr/local/lib/python3.6/site-packages/nlpaug/base_augmenter.py", line 5, in <module>
|     from nlpaug.util import Action, Method, WarningException, WarningName, WarningCode, WarningMessage
|   File "/usr/local/lib/python3.6/site-packages/nlpaug/util/__init__.py", line 7, in <module>
|     from nlpaug.util.visual import *
|   File "/usr/local/lib/python3.6/site-packages/nlpaug/util/visual/__init__.py", line 1, in <module>
|     from nlpaug.util.visual.spectrogram import *
|   File "/usr/local/lib/python3.6/site-packages/nlpaug/util/visual/spectrogram.py", line 2, in <module>
|     import librosa.display
| ModuleNotFoundError: No module named 'librosa'
@chiragjn chiragjn changed the title Hard dependency on librosa because of star imports Hard dependency on librosa because of package level import Nov 16, 2019
@makcedward makcedward added the bug Something isn't working label Nov 16, 2019
@makcedward
Copy link
Owner

Will remove hard dependency in next release.

@makcedward
Copy link
Owner

Included this fix in 0.0.11 release.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

No branches or pull requests

2 participants