Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Casper Wallet | Onboarding | Finishing onboarding with only 1 active browser tab ends up in closing browser #482

Open
karatnyk opened this issue Jan 25, 2023 · 3 comments
Assignees
Labels
bug Something isn't working

Comments

@karatnyk
Copy link

Pre-conditions:
A Wallet is freshly installed, Onboarding is in progress
No other active browser tabs/windows except the one with ongoing onboarding is opened

Steps to reproduce:
Go thorough the onboarding till the last 'Congrats! Your Casper Wallet is set up...' screen
Click on 'Got It' button

Expected result: Onboarding is finished but browser is not closed
Actual result: Browser is closed

1. Finishing onboarding with only 1 active browser tab ends up in closing browser.gif

@karatnyk karatnyk added the bug Something isn't working label Jan 25, 2023
@piotrwitek piotrwitek assigned piotrwitek and ost-ptk and unassigned piotrwitek and ost-ptk Jan 25, 2023
@piotrwitek
Copy link
Contributor

@adammake we need a specification as a current suggestion to Onboarding is finished but browser is not closed is not an acceptable solution as it is a built-in browser behavior and cannot be changed.

@piotrwitek piotrwitek assigned adammake and unassigned piotrwitek Jan 31, 2023
@adammake
Copy link
Member

adammake commented Feb 4, 2023

If we roll out a fullscreen experience we could address this issue. Putting this on ice for now.

@piotrwitek
Copy link
Contributor

@adammake you could fix that by redirecting to a special follow-up getting started page, that would fix this issue and also address another => onboarding ends up abruptly.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

No branches or pull requests

4 participants