Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Settings not loaded properly #223

Closed
alfredorusso-github opened this issue Mar 31, 2023 · 4 comments
Closed

Settings not loaded properly #223

alfredorusso-github opened this issue Mar 31, 2023 · 4 comments
Assignees

Comments

@alfredorusso-github
Copy link

There is a bug that prevents changing the settings in MakeHuman. The bug is related to an error that occurs when MakeHuman is started, which prevents the settings from being correctly loaded. As a result, the default settings are created and utilized every time, and some plugins cannot be activated.

This issue needs to be addressed in order to enable changing the settings and activating all plugins.

The error is caused by the parseINI method in the /makehuman/lib/inifile.py file. In this method, json.loads(s, encoding='utf-8') is used. However, since Python 3.9, the encoding keyword argument is deprecated and it is no longer necessary to specify the encoding type. The method itself calls detect_encoding(), which is able to recognize the input encoding.

The solution for the bug that worked for me is the following:
inifile.zip

@Aranuvir
Copy link
Collaborator

Strangely MakeHuman does not show an error on my system. Though I can reproduce the issue in a quick test in Python. Evaluating your explanation and checking the documentation this seems to be quite reasonable. Should be fixed soon...

@Aranuvir
Copy link
Collaborator

Should be fixed with commit 4f37318.

Closing. Could be reopened in case there are further issues.

@black-punkduck
Copy link
Contributor

should be okay.

settings.ini usually can have two topics with none ASCII codes:

pathnames with special characters ... what about German "öffentlicher Ordner" ;)

Awful tags. And there we already have one. Makehuman + the TM symbol. But afaik it works with JSON.

The discussion what JSON can do or can't do in stackexchange is endless. It is usually more a problem around HTML or Java-Script or when APIs will classically deliver nothing (from daily business) but an error-code ...

the other .ini files are just tables and not JSON.

@Aranuvir
Copy link
Collaborator

Feel free to change the tags ;)

Btw, I had fixed that issue 4 years ago. And I cannot tell from the history how the code was reverted. Confusing.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

4 participants