Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Eslint checks not working on poolparty deploy #1254

Closed
ofqwx opened this issue Apr 3, 2021 · 0 comments · Fixed by #1255
Closed

Eslint checks not working on poolparty deploy #1254

ofqwx opened this issue Apr 3, 2021 · 0 comments · Fixed by #1255
Assignees
@ofqwx
Labels
bug Something isn't working

Comments

@ofqwx
Copy link

ofqwx commented Apr 3, 2021

Describe the bug
After Flow types were implemented, babel-eslint plugin was needed as dependency and for some reason this plugin is not found by eslint config in ubuntu environments. This plugin was officially moved to @babel/eslint-parser and it seems issues were fixed there. Solution would be to upgrade to that version, adapting/upgrading some existing packages.

To Reproduce
Steps to reproduce the behavior:
Not reproducible since we've disabled eslint checks for now.

Expected behavior
Poolparty should be able to execute eslint checks with no issues.
@ofqwx ofqwx added the bug Something isn't working label Apr 3, 2021
@ofqwx ofqwx self-assigned this Apr 3, 2021
@ofqwx ofqwx mentioned this issue Apr 3, 2021
Merged
14 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@ofqwx ofqwx

Labels
bug Something isn't working
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Add @babel/eslint-parser makerdao/community
1 participant
@ofqwx