Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Menu-Button, Listbox-button: clean up the configuration #146

Open
saiponnada opened this issue Mar 14, 2024 · 0 comments
Open

Menu-Button, Listbox-button: clean up the configuration #146

saiponnada opened this issue Mar 14, 2024 · 0 comments

Comments

@saiponnada
Copy link
Contributor

I think one thing we might need to do is make it clearer that some of these options are only valid for the single select (i.e. role=menuitemradio) variant. Maybe we could move those into a sub mapping? Or any other ideas?

const defaultOptions = {
customElementMode: false,
expandedClass: "menu-button--expanded",
menuSelector: ".menu-button__menu",
buttonTextSelector: .btn__text,
singleSelect: {
buttonValueType: "text", // ["text", "icon", "both"],
menuItemIconSelector: ".icon",
menuItemButtonAriaLabelSelector: null,
}
};

@saiponnada saiponnada changed the title Menu-Button: clean up the configuration Menu-Button, Listbox-button: clean up the configuration Mar 14, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant