Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Not using $XDG_CONFIG_HOME on Windows #255

Closed
cpkio opened this issue Sep 23, 2021 · 2 comments
Closed

Not using $XDG_CONFIG_HOME on Windows #255

cpkio opened this issue Sep 23, 2021 · 2 comments
Labels
enhancement New feature or request
Milestone

Comments

@cpkio
Copy link

cpkio commented Sep 23, 2021

I have $XDG_CONFIG_HOME set in Windows (since I use Neovim daily). But Amfora seems to be ignoring it: expected to see Amfora config in my Neovim directory, but *.toml are in my $APPDATA\Roaming\amfora anyway.

Probably it would be better to provide a separate environment value for config path, so that Amfora could be made portable.

@makew0rld
Copy link
Owner

That's correct, Amfora only looks at that variable on *nix systems. I can change that though, I guess there's no harm.

I will get around to doing this, or would accept a PR.

@makew0rld makew0rld added the enhancement New feature or request label Sep 27, 2021
@makew0rld makew0rld added this to the v1.9.0 milestone Sep 27, 2021
@makew0rld makew0rld changed the title Amfora not respecting $XDG_CONFIG_HOME (in Windows only?) Amfora not using $XDG_CONFIG_HOME on Windows Sep 27, 2021
@makew0rld makew0rld changed the title Amfora not using $XDG_CONFIG_HOME on Windows Not using $XDG_CONFIG_HOME on Windows Sep 27, 2021
@makew0rld
Copy link
Owner

Fixed, this will be in v1.9.0. Technically this could mess up some people's setups if they had this variable set but also had a custom config in the APPDATA folder. Also applies to bookmarks and subscriptions. But I suspect this is very rare, and the files aren't deleted anyway. It will be mentioned in the release notes.

@makew0rld makew0rld mentioned this issue Dec 7, 2021
16 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

No branches or pull requests

2 participants