-
-
Notifications
You must be signed in to change notification settings - Fork 311
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
String as marker #22
Comments
What would you expect that to do? Basically annotations?
That's an artifact from text rendering bein pretty much a scatter plot of chars. |
Yes
Ah, I see were the problem comes from. |
A nicer way of not converting the marker to a string, would be to allow Annotations are pretty much implemented in GLVisualize, I just need to wrap the function and export it in Makie :) |
Yes, allowing that in GLVisualize would be best. Still I think there is a bug here: |
Why not? Symbols are just a stand in for unicode characters, and a bunch of unicode characters are represented as a string ;) |
The issue in short:
|
Ahhh, sorry, since you never mentioned that it actually errors, I was a bit slow to follow ;) |
That was mutual, it took me also to figure out that it actually should work. |
Oh, well no wonder why i didn't see the problem with it - the conversion code is correct, but I don't have the scatter code setup to actually deal with strings for multiple markers :D |
Okay this should be fixed on GLVisualize master and this branch: #24 |
Works! |
It would be nice to use Strings as markers in
scatter
.https://github.com/SimonDanisch/Makie.jl/blob/cef849737a6833c2b96987025c1b90bf4ec1da25/src/plotsbase/converts.jl#L324 also seems strange. Cheers
The text was updated successfully, but these errors were encountered: