Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Unused line / define defaults? #28

Closed
behinger opened this issue Mar 24, 2023 · 0 comments · Fixed by #29
Closed

Unused line / define defaults? #28

behinger opened this issue Mar 24, 2023 · 0 comments · Fixed by #29

Comments

@behinger
Copy link
Collaborator

I didnt fully understand this line of code - do we need it?

It seems to be a stub to use the default values. params is not used though?

params = Iterators.filter(((k, v),) -> !(v isa Nothing), Dict(:tol => ct.tol, :maxiter => ct.maxiter, :rescale => ct.rescale))

Context:

function (ct::ClaughTochter)(
xrange::LinRange, yrange::LinRange,
positions::AbstractVector{<: Point{2}}, data::AbstractVector{<:Number})
params = Iterators.filter(((k, v),) -> !(v isa Nothing), Dict(:tol => ct.tol, :maxiter => ct.maxiter, :rescale => ct.rescale))
interp = SciPy.interpolate.CloughTocher2DInterpolator(
Tuple.(positions), data;
tol=ct.tol, maxiter=ct.maxiter, rescale=ct.rescale)
return collect(interp(xrange' .* ones(length(yrange)), ones(length(xrange))' .* yrange)')

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

1 participant