Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix reentrancy bug #45

Closed
makoto opened this issue Mar 4, 2017 · 1 comment
Closed

Fix reentrancy bug #45

makoto opened this issue Mar 4, 2017 · 1 comment

Comments

@makoto
Copy link
Owner

makoto commented Mar 4, 2017

This could cause reentrancy bug

	function withdraw() public onlyPayable notPaid {
		Participant participant = participants[msg.sender];
		if (msg.sender.send(participant.payout)) {
			participant.paid = true;
			totalBalance -= participant.payout;
		}
	}

@makoto makoto added the security label Mar 4, 2017
@makoto
Copy link
Owner Author

makoto commented Mar 17, 2017

Fixed at #47

@makoto makoto closed this as completed Mar 17, 2017
@makoto makoto added the bug label Feb 24, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

1 participant