Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Don't duplicate stuff #9

Closed
malakada opened this issue May 9, 2015 · 1 comment
Closed

Don't duplicate stuff #9

malakada opened this issue May 9, 2015 · 1 comment

Comments

@malakada
Copy link
Owner

malakada commented May 9, 2015

var FilterableIssueList = React.createClass({ getInitialState: function() { return { displayClosed: false, issues: [], repo: 'andrewrk/groovebasin', }; },

is the same as:

var SearchBar = React.createClass({ getInitialState: function() { return { displayClosed: false, repo: 'andrewrk/groovebasin', }; },

This should be consolidated into one location.

@malakada
Copy link
Owner Author

So on a closer review, this is actually good/ok because it individually/locally needs to keep track of the state of the checkbox, and one component should not rely on another component for this information. Closing because this is actually correct.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant