Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Refactor using FPS #461

Open
davidbrochart opened this issue Oct 12, 2021 · 2 comments
Open

Refactor using FPS #461

davidbrochart opened this issue Oct 12, 2021 · 2 comments

Comments

@davidbrochart
Copy link
Contributor

FPS is a framework for composing a server as a set of plugins, which implement routers and configurations. It is used to implement a Jupyter server in jupyverse.
Quetz could be implemented using FPS. Could we do it incrementally, and if so, where should we start?

@wolfv
Copy link
Member

wolfv commented Oct 12, 2021

Yeah, I guess we could. The big question is what's the ROI? :)
I think currently we could have the biggest user facing impact with some UI changes to quetz-frontend.

However, one area that I am quite interested in would be to share some auth level design. I am looking at GitHub's way of having permissions were one can have scopes per Token (and similar, probably per user).
It would be cool to unify this so that we could share the implementation of these scopes with the idea that they could later be merged under one hood.

Screenshot 2021-10-12 at 12 47 43

@SylvainCorlay
Copy link
Member

I think that the code and tooling reuse is the main argument

  • share fps-auth,
  • adopt jupyter-packaging for releases for better automation.

etc.

Overall, I think it will reduce the "social overhead" between parts of the team working on jupyter and the part of the team working on quetz.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants