Skip to content

Commit

Permalink
Maintenance:
Browse files Browse the repository at this point in the history 
* Removed empty nl_examples from dist.mak
* Added copyright acknowledgements and full text of licenses to binary distribution
* Fixed up the list of third-party libraries
* Moved WDL fft.c to 3rdparty
  • Loading branch information
@cuavas
cuavas committed Mar 4, 2020
1 parent 4080e50 commit 11ac745
Show file tree
Hide file tree
Showing 19 changed files with 2,650 additions and 1,302 deletions.
12 changes: 7 additions & 5 deletions 3rdparty/README.md
View file
Original file line number Diff line number Diff line change
Expand Up @@ -24,11 +24,11 @@ genie - [The BSD 3-Clause License](http://opensource.org/licenses/BSD-3-Clause)

glm - [The MIT License (MIT)](http://opensource.org/licenses/MIT)

libflac - [The BSD 3-Clause License](http://opensource.org/licenses/BSD-3-Clause)
libflac - [The BSD 3-Clause License](http://opensource.org/licenses/BSD-3-Clause) (codecs), [The GNU General Public License, version 2](https://opensource.org/licenses/GPL-2.0)

libjpeg - [Custom BSD-like](https://github.com/numenta/nupic/blob/master/external/licenses/LICENSE.libjpeg-6b.txt)

linenoise-ng - [The BSD 3-Clause License](http://opensource.org/licenses/BSD-3-Clause)
linenoise - [The BSD 2-Clause License](http://opensource.org/licenses/BSD-2-Clause)

lsqlite3 - [The MIT License (MIT)](http://opensource.org/licenses/MIT)

Expand All @@ -40,7 +40,7 @@ lua-zlib - [The MIT License (MIT)](http://opensource.org/licenses/MIT)

luafilesystem - [The MIT License (MIT)](http://opensource.org/licenses/MIT)

lzma - [The GNU Lesser General Public License](http://opensource.org/licenses/LGPL-2.1)
lzma - Custom public domain license

minimp3 - [Creative Commons Zero v1.0 Universal](https://creativecommons.org/publicdomain/zero/1.0/)

Expand All @@ -52,7 +52,7 @@ portmidi - [The MIT License (MIT)](http://opensource.org/licenses/MIT)

pugixml - [The MIT License (MIT)](http://opensource.org/licenses/MIT)

rapidjson - [The BSD 3-Clause License](http://opensource.org/licenses/BSD-3-Clause)
rapidjson - [The MIT License (MIT)](http://opensource.org/licenses/MIT), [The BSD 3-Clause License](http://opensource.org/licenses/BSD-3-Clause) (msinttypes), JSON license (JSON_checker)

sdl2 - [zlib license](http://opensource.org/licenses/Zlib)

Expand All @@ -62,12 +62,14 @@ softfloat3 - [The BSD 3-Clause License](http://opensource.org/licenses/BSD-3-Cla

sol2 - [The MIT License (MIT)](http://opensource.org/licenses/MIT)

sqlite3 - Public Domain
sqlite3 - Custom public domain license

tap-windows6.h - Dual-licensed [The GNU General Public License, version 2](https://opensource.org/licenses/GPL-2.0) and [The MIT License (MIT)](http://opensource.org/licenses/MIT)

utf8proc - [The MIT License (MIT)](http://opensource.org/licenses/MIT)

wdlfft - [zlib license](http://opensource.org/licenses/Zlib)

winpcap - [The BSD 3-Clause License](http://opensource.org/licenses/BSD-3-Clause)

zlib - [zlib license](http://opensource.org/licenses/Zlib)
Loading

3 comments on commit 11ac745

@Tafoid
Copy link
Contributor

@Tafoid Tafoid commented on 11ac745 Mar 6, 2020

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Not sure, but vgmplay seems to have lost most of the functionality that was added
vgmplay-diff

@cuavas
Copy link
Member Author

@cuavas cuavas commented on 11ac745 Mar 6, 2020

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It did break, but I’m not sure why. When I moved the FFT code to a separate library, I grabbed a clean copy of it from github. That shouldn't be a problem, as @MooglyGuy didn’t substantially edit it when adding it to the source. I tried rolling back the change to vgm_visualizer.cpp itself (static/constexpr), and that makes no difference. On the bright side, it doesn’t seem to depend on the compiler or OS - it's broken in the same way when built with GCC on Windows and clang on Linux. I ran it in a debugger quickly, and the FFT functions are being called from the right places. I’m at a loss right now, I’ll look at it again later. Sorry.

@cuavas
Copy link
Member Author

@cuavas cuavas commented on 11ac745 Mar 6, 2020

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Never mind, I see what the difference is.

Please sign in to comment.