Skip to content

Commit

Permalink
Removed nearly all custom MCFG macros from eepromser, migrated more o…
Browse files Browse the repository at this point in the history 
…f policetr to newer syntax, nw
  • Loading branch information
@MooglyGuy
MooglyGuy committed Jun 7, 2018
1 parent 6bc8399 commit b66e57a
Show file tree
Hide file tree
Showing 142 changed files with 380 additions and 423 deletions.
2 changes: 1 addition & 1 deletion src/devices/bus/centronics/epson_lx810l.cpp
View file
Original file line number Diff line number Diff line change
Expand Up @@ -159,7 +159,7 @@ MACHINE_CONFIG_START(epson_lx810l_device::device_add_mconfig)
MCFG_E05A30_CENTRONICS_SELECT_CALLBACK(WRITELINE(*this, epson_lx810l_device, e05a30_centronics_select))

/* 256-bit eeprom */
MCFG_EEPROM_SERIAL_93C06_ADD("eeprom")
MCFG_DEVICE_ADD("eeprom", EEPROM_SERIAL_93C06_16BIT)

/* steppers */
MCFG_STEPPER_ADD("pf_stepper")
Expand Down
4 changes: 2 additions & 2 deletions src/devices/bus/isa/mach32.cpp
View file
Original file line number Diff line number Diff line change
Expand Up @@ -50,7 +50,7 @@ mach32_device::mach32_device(const machine_config &mconfig, device_type type, co
MACHINE_CONFIG_START(mach32_device::device_add_mconfig)
MCFG_DEVICE_ADD("8514a", ATIMACH32_8514A, 0)
downcast<ibm8514a_device*>(device)->set_vga(DEVICE_SELF);
MCFG_EEPROM_SERIAL_93C56_ADD("ati_eeprom")
MCFG_DEVICE_ADD("ati_eeprom", EEPROM_SERIAL_93C56_16BIT)
MACHINE_CONFIG_END

void mach32_8514a_device::device_start()
Expand Down Expand Up @@ -336,7 +336,7 @@ mach64_device::mach64_device(const machine_config &mconfig, device_type type, co
MACHINE_CONFIG_START(mach64_device::device_add_mconfig)
MCFG_DEVICE_ADD("8514a", ATIMACH64_8514A, 0)
downcast<ibm8514a_device*>(device)->set_vga(DEVICE_SELF);
MCFG_EEPROM_SERIAL_93C56_ADD("ati_eeprom")
MCFG_DEVICE_ADD("ati_eeprom", EEPROM_SERIAL_93C56_16BIT)
MACHINE_CONFIG_END

void mach64_8514a_device::device_start()
Expand Down
2 changes: 1 addition & 1 deletion src/devices/bus/sega8/rom.cpp
View file
Original file line number Diff line number Diff line change
Expand Up @@ -715,7 +715,7 @@ WRITE8_MEMBER(sega8_eeprom_device::write_mapper)
}

MACHINE_CONFIG_START(sega8_eeprom_device::device_add_mconfig)
MCFG_EEPROM_SERIAL_93C46_ADD("eeprom")
MCFG_DEVICE_ADD("eeprom", EEPROM_SERIAL_93C46_16BIT)
MACHINE_CONFIG_END


Expand Down
26 changes: 13 additions & 13 deletions src/devices/machine/eepromser.cpp
View file
Original file line number Diff line number Diff line change
Expand Up @@ -155,10 +155,10 @@ ALLOW_SAVE_TYPE(eeprom_serial_base_device::eeprom_state);
// eeprom_serial_base_device - constructor
//-------------------------------------------------

eeprom_serial_base_device::eeprom_serial_base_device(const machine_config &mconfig, device_type devtype, const char *tag, device_t *owner)
eeprom_serial_base_device::eeprom_serial_base_device(const machine_config &mconfig, device_type devtype, const char *tag, device_t *owner, bool enable_streaming)
: eeprom_base_device(mconfig, devtype, tag, owner),
m_command_address_bits(0),
m_streaming_enabled(false),
m_streaming_enabled(enable_streaming),
m_output_on_falling_clock_enabled(false),
m_do_cb(*this),
m_state(STATE_IN_RESET),
Expand Down Expand Up @@ -625,8 +625,8 @@ void eeprom_serial_base_device::execute_write_command()
// eeprom_serial_93cxx_device - constructor
//-------------------------------------------------

eeprom_serial_93cxx_device::eeprom_serial_93cxx_device(const machine_config &mconfig, device_type devtype, const char *tag, device_t *owner)
: eeprom_serial_base_device(mconfig, devtype, tag, owner)
eeprom_serial_93cxx_device::eeprom_serial_93cxx_device(const machine_config &mconfig, device_type devtype, const char *tag, device_t *owner, bool enable_streaming)
: eeprom_serial_base_device(mconfig, devtype, tag, owner, enable_streaming)
{
}

Expand Down Expand Up @@ -692,8 +692,8 @@ WRITE_LINE_MEMBER(eeprom_serial_93cxx_device::di_write) { base_di_write(state);
// eeprom_serial_er5911_device - constructor
//-------------------------------------------------

eeprom_serial_er5911_device::eeprom_serial_er5911_device(const machine_config &mconfig, device_type devtype, const char *tag, device_t *owner)
: eeprom_serial_base_device(mconfig, devtype, tag, owner)
eeprom_serial_er5911_device::eeprom_serial_er5911_device(const machine_config &mconfig, device_type devtype, const char *tag, device_t *owner, bool enable_streaming)
: eeprom_serial_base_device(mconfig, devtype, tag, owner, enable_streaming)
{
}

Expand Down Expand Up @@ -760,8 +760,8 @@ WRITE_LINE_MEMBER(eeprom_serial_er5911_device::di_write) { base_di_write(state);
// eeprom_serial_x24c44_device - constructor
//-------------------------------------------------

eeprom_serial_x24c44_device::eeprom_serial_x24c44_device(const machine_config &mconfig, device_type devtype, const char *tag, device_t *owner)
: eeprom_serial_base_device(mconfig, devtype, tag, owner)
eeprom_serial_x24c44_device::eeprom_serial_x24c44_device(const machine_config &mconfig, device_type devtype, const char *tag, device_t *owner, bool enable_streaming)
: eeprom_serial_base_device(mconfig, devtype, tag, owner, enable_streaming)
{
}

Expand Down Expand Up @@ -1123,8 +1123,8 @@ WRITE_LINE_MEMBER(eeprom_serial_x24c44_device::di_write) { base_di_write(state);

// macro for defining a new device class
#define DEFINE_SERIAL_EEPROM_DEVICE(_baseclass, _lowercase, _uppercase, _bits, _cells, _addrbits) \
eeprom_serial_##_lowercase##_##_bits##bit_device::eeprom_serial_##_lowercase##_##_bits##bit_device(const machine_config &mconfig, const char *tag, device_t *owner, uint32_t clock) \
: eeprom_serial_##_baseclass##_device(mconfig, EEPROM_SERIAL_##_uppercase##_##_bits##BIT, tag, owner) \
eeprom_serial_##_lowercase##_##_bits##bit_device::eeprom_serial_##_lowercase##_##_bits##bit_device(const machine_config &mconfig, const char *tag, device_t *owner, uint32_t clock, bool enable_streaming) \
: eeprom_serial_##_baseclass##_device(mconfig, EEPROM_SERIAL_##_uppercase##_##_bits##BIT, tag, owner, (bool)enable_streaming) \
{ \
set_size(_cells, _bits); \
set_address_bits(_addrbits); \
Expand All @@ -1142,9 +1142,9 @@ DEFINE_SERIAL_EEPROM_DEVICE(93cxx, 93c86, 93C86, 16, 1024, 10)

// Seiko S-29X90 class of 16-bit EEPROMs. They always use 13 address bits, despite needing only 6-8.
// The output is updated on the falling edge of the clock. Streaming is enabled
DEFINE_SERIAL_EEPROM_DEVICE(93cxx, s29190, S29190, 16, 64, 13)
DEFINE_SERIAL_EEPROM_DEVICE(93cxx, s29290, S29290, 16, 128, 13)
DEFINE_SERIAL_EEPROM_DEVICE(93cxx, s29390, S29390, 16, 256, 13)
DEFINE_SERIAL_EEPROM_DEVICE(s29x90, s29190, S29190, 16, 64, 13)
DEFINE_SERIAL_EEPROM_DEVICE(s29x90, s29290, S29290, 16, 128, 13)
DEFINE_SERIAL_EEPROM_DEVICE(s29x90, s29390, S29390, 16, 256, 13)

// some manufacturers use pin 6 as an "ORG" pin which, when pulled low, configures memory for 8-bit accesses
DEFINE_SERIAL_EEPROM_DEVICE(93cxx, 93c46, 93C46, 8, 128, 7)
Expand Down
106 changes: 27 additions & 79 deletions src/devices/machine/eepromser.h
View file
Original file line number Diff line number Diff line change
Expand Up @@ -20,77 +20,6 @@
// INTERFACE CONFIGURATION MACROS
//**************************************************************************

// optional enable for streaming reads
#define MCFG_EEPROM_SERIAL_ENABLE_STREAMING() \
downcast<eeprom_serial_base_device &>(*device).enable_streaming(true);
// optional enable for output on falling clock
#define MCFG_EEPROM_SERIAL_ENABLE_OUTPUT_ON_FALLING_CLOCK() \
downcast<eeprom_serial_base_device &>(*device).enable_output_on_falling_clock(true);

// standard 93CX6 class of 16-bit EEPROMs
#define MCFG_EEPROM_SERIAL_93C06_ADD(_tag) \
MCFG_DEVICE_ADD(_tag, EEPROM_SERIAL_93C06_16BIT)
#define MCFG_EEPROM_SERIAL_93C46_ADD(_tag) \
MCFG_DEVICE_ADD(_tag, EEPROM_SERIAL_93C46_16BIT)
#define MCFG_EEPROM_SERIAL_93C56_ADD(_tag) \
MCFG_DEVICE_ADD(_tag, EEPROM_SERIAL_93C56_16BIT)
#define MCFG_EEPROM_SERIAL_93C57_ADD(_tag) \
MCFG_DEVICE_ADD(_tag, EEPROM_SERIAL_93C57_16BIT)
#define MCFG_EEPROM_SERIAL_93C66_ADD(_tag) \
MCFG_DEVICE_ADD(_tag, EEPROM_SERIAL_93C66_16BIT)
#define MCFG_EEPROM_SERIAL_93C76_ADD(_tag) \
MCFG_DEVICE_ADD(_tag, EEPROM_SERIAL_93C76_16BIT)
#define MCFG_EEPROM_SERIAL_93C86_ADD(_tag) \
MCFG_DEVICE_ADD(_tag, EEPROM_SERIAL_93C86_16BIT)

// some manufacturers use pin 6 as an "ORG" pin which, when pulled low, configures memory for 8-bit accesses
#define MCFG_EEPROM_SERIAL_93C46_8BIT_ADD(_tag) \
MCFG_DEVICE_ADD(_tag, EEPROM_SERIAL_93C46_8BIT)
#define MCFG_EEPROM_SERIAL_93C56_8BIT_ADD(_tag) \
MCFG_DEVICE_ADD(_tag, EEPROM_SERIAL_93C56_8BIT)
#define MCFG_EEPROM_SERIAL_93C57_8BIT_ADD(_tag) \
MCFG_DEVICE_ADD(_tag, EEPROM_SERIAL_93C57_8BIT)
#define MCFG_EEPROM_SERIAL_93C66_8BIT_ADD(_tag) \
MCFG_DEVICE_ADD(_tag, EEPROM_SERIAL_93C66_8BIT)
#define MCFG_EEPROM_SERIAL_93C76_8BIT_ADD(_tag) \
MCFG_DEVICE_ADD(_tag, EEPROM_SERIAL_93C76_8BIT)
#define MCFG_EEPROM_SERIAL_93C86_8BIT_ADD(_tag) \
MCFG_DEVICE_ADD(_tag, EEPROM_SERIAL_93C86_8BIT)

// ER5911 has a separate ready pin, a reduced command set, and supports 8/16 bit out of the box
#define MCFG_EEPROM_SERIAL_ER5911_8BIT_ADD(_tag) \
MCFG_DEVICE_ADD(_tag, EEPROM_SERIAL_ER5911_8BIT)
#define MCFG_EEPROM_SERIAL_ER5911_16BIT_ADD(_tag) \
MCFG_DEVICE_ADD(_tag, EEPROM_SERIAL_ER5911_16BIT)

#define MCFG_EEPROM_SERIAL_MSM16911_8BIT_ADD(_tag) \
MCFG_DEVICE_ADD(_tag, EEPROM_SERIAL_MSM16911_8BIT)
#define MCFG_EEPROM_SERIAL_MSM16911_16BIT_ADD(_tag) \
MCFG_DEVICE_ADD(_tag, EEPROM_SERIAL_MSM16911_16BIT)

// Seiko S-29X90 class of 16-bit EEPROMs. They always use 13 address bits, despite needing only 6-8.
// The output is updated on the falling edge of the clock. Streaming is enabled
#define MCFG_EEPROM_SERIAL_S29190_ADD(_tag) \
MCFG_DEVICE_ADD(_tag, EEPROM_SERIAL_S29190_16BIT) \
MCFG_EEPROM_SERIAL_ENABLE_OUTPUT_ON_FALLING_CLOCK() \
MCFG_EEPROM_SERIAL_ENABLE_STREAMING()
#define MCFG_EEPROM_SERIAL_S29290_ADD(_tag) \
MCFG_DEVICE_ADD(_tag, EEPROM_SERIAL_S29290_16BIT) \
MCFG_EEPROM_SERIAL_ENABLE_OUTPUT_ON_FALLING_CLOCK() \
MCFG_EEPROM_SERIAL_ENABLE_STREAMING()
#define MCFG_EEPROM_SERIAL_S29390_ADD(_tag) \
MCFG_DEVICE_ADD(_tag, EEPROM_SERIAL_S29390_16BIT) \
MCFG_EEPROM_SERIAL_ENABLE_OUTPUT_ON_FALLING_CLOCK() \
MCFG_EEPROM_SERIAL_ENABLE_STREAMING()

// X24c44 16 bit ram/eeprom combo
#define MCFG_EEPROM_SERIAL_X24C44_ADD(_tag) \
MCFG_DEVICE_ADD(_tag, EEPROM_SERIAL_X24C44_16BIT)

// pass-throughs to the base class for setting default data
#define MCFG_EEPROM_SERIAL_DATA MCFG_EEPROM_DATA
#define MCFG_EEPROM_SERIAL_DEFAULT_VALUE MCFG_EEPROM_DEFAULT_VALUE

#define MCFG_EEPROM_SERIAL_DO_CALLBACK(_devcb) \
devcb = &downcast<eeprom_serial_base_device &>(*device).set_do_callback(DEVCB_##_devcb);

Expand All @@ -99,6 +28,11 @@
// TYPE DEFINITIONS
//**************************************************************************

enum : bool
{
EEPROM_SERIAL_NO_STREAMING = false,
EEPROM_SERIAL_ENABLE_STREAMING = true
};

// ======================> eeprom_serial_base_device

Expand All @@ -113,7 +47,7 @@ class eeprom_serial_base_device : public eeprom_base_device

protected:
// construction/destruction
eeprom_serial_base_device(const machine_config &mconfig, device_type devtype, const char *tag, device_t *owner);
eeprom_serial_base_device(const machine_config &mconfig, device_type devtype, const char *tag, device_t *owner, bool enable_streaming = EEPROM_SERIAL_NO_STREAMING);

// device-level overrides
virtual void device_start() override;
Expand Down Expand Up @@ -211,13 +145,27 @@ class eeprom_serial_93cxx_device : public eeprom_serial_base_device

protected:
// construction/destruction
eeprom_serial_93cxx_device(const machine_config &mconfig, device_type devtype, const char *tag, device_t *owner);
eeprom_serial_93cxx_device(const machine_config &mconfig, device_type devtype, const char *tag, device_t *owner, bool enable_streaming = EEPROM_SERIAL_NO_STREAMING);

// subclass overrides
virtual void parse_command_and_address() override;
};


// ======================> eeprom_serial_s29x90_device

class eeprom_serial_s29x90_device : public eeprom_serial_93cxx_device
{
protected:
// construction/destruction
eeprom_serial_s29x90_device(const machine_config &mconfig, device_type devtype, const char *tag, device_t *owner, bool ignored = EEPROM_SERIAL_NO_STREAMING)
: eeprom_serial_93cxx_device(mconfig, devtype, tag, owner, true)
{
enable_output_on_falling_clock(true);
}
};


// ======================> eeprom_serial_er5911_device

class eeprom_serial_er5911_device : public eeprom_serial_base_device
Expand All @@ -234,7 +182,7 @@ class eeprom_serial_er5911_device : public eeprom_serial_base_device

protected:
// construction/destruction
eeprom_serial_er5911_device(const machine_config &mconfig, device_type devtype, const char *tag, device_t *owner);
eeprom_serial_er5911_device(const machine_config &mconfig, device_type devtype, const char *tag, device_t *owner, bool enable_streaming = EEPROM_SERIAL_NO_STREAMING);

// subclass overrides
virtual void parse_command_and_address() override;
Expand All @@ -258,7 +206,7 @@ class eeprom_serial_x24c44_device : public eeprom_serial_base_device

protected:
// construction/destruction
eeprom_serial_x24c44_device(const machine_config &mconfig, device_type devtype, const char *tag, device_t *owner);
eeprom_serial_x24c44_device(const machine_config &mconfig, device_type devtype, const char *tag, device_t *owner, bool enable_streaming = EEPROM_SERIAL_NO_STREAMING);

// subclass overrides
virtual void parse_command_and_address() override;
Expand All @@ -285,7 +233,7 @@ class eeprom_serial_x24c44_device : public eeprom_serial_base_device
class eeprom_serial_##_lowercase##_##_bits##bit_device : public eeprom_serial_##_baseclass##_device \
{ \
public: \
eeprom_serial_##_lowercase##_##_bits##bit_device(const machine_config &mconfig, const char *tag, device_t *owner, uint32_t clock = 0); \
eeprom_serial_##_lowercase##_##_bits##bit_device(const machine_config &mconfig, const char *tag, device_t *owner, uint32_t clock = 0, bool enable_streaming = EEPROM_SERIAL_NO_STREAMING); \
}; \
DECLARE_DEVICE_TYPE(EEPROM_SERIAL_##_uppercase##_##_bits##BIT, eeprom_serial_##_lowercase##_##_bits##bit_device)

Expand Down Expand Up @@ -314,9 +262,9 @@ DECLARE_SERIAL_EEPROM_DEVICE(er5911, msm16911, MSM16911, 16)

// Seiko S-29X90 class of 16-bit EEPROMs. They always use 13 address bits, despite needing only 6-8.
// The output is updated on the falling edge of the clock. Streaming is enabled
DECLARE_SERIAL_EEPROM_DEVICE(93cxx, s29190, S29190, 16)
DECLARE_SERIAL_EEPROM_DEVICE(93cxx, s29290, S29290, 16)
DECLARE_SERIAL_EEPROM_DEVICE(93cxx, s29390, S29390, 16)
DECLARE_SERIAL_EEPROM_DEVICE(s29x90, s29190, S29190, 16)
DECLARE_SERIAL_EEPROM_DEVICE(s29x90, s29290, S29290, 16)
DECLARE_SERIAL_EEPROM_DEVICE(s29x90, s29390, S29390, 16)

// X24c44 16 bit 32byte ram/eeprom combo
DECLARE_SERIAL_EEPROM_DEVICE(x24c44, x24c44, X24C44, 16)
Expand Down
4 changes: 0 additions & 4 deletions src/devices/sound/bsmt2000.h
View file
Original file line number Diff line number Diff line change
Expand Up @@ -20,10 +20,6 @@
// INTERFACE CONFIGURATION MACROS
//**************************************************************************

#define MCFG_BSMT2000_ADD(_tag, _clock) \
MCFG_DEVICE_ADD(_tag, BSMT2000, _clock)
#define MCFG_BSMT2000_REPLACE(_tag, _clock) \
MCFG_DEVICE_REPLACE(_tag, BSMT2000, _clock)
#define MCFG_BSMT2000_READY_CALLBACK(_class, _method) \
downcast<bsmt2000_device &>(*device).set_ready_callback(bsmt2000_device::ready_callback(&_class::_method, #_class "::" #_method, nullptr, (_class *)nullptr));

Expand Down
1 change: 1 addition & 0 deletions src/devices/video/ef9369.cpp
View file
Original file line number Diff line number Diff line change
Expand Up @@ -11,6 +11,7 @@

#include <algorithm>

/*static*/ constexpr int ef9369_device::NUMCOLORS;

//**************************************************************************
// DEVICE DEFINITIONS
Expand Down
2 changes: 1 addition & 1 deletion src/devices/video/pc_vga.cpp
View file
Original file line number Diff line number Diff line change
Expand Up @@ -2219,7 +2219,7 @@ WRITE8_MEMBER(vga_device::mem_linear_w)

MACHINE_CONFIG_START(ati_vga_device::device_add_mconfig)
MCFG_MACH8_ADD_OWNER("8514a")
MCFG_EEPROM_SERIAL_93C46_ADD("ati_eeprom")
MCFG_DEVICE_ADD("ati_eeprom", EEPROM_SERIAL_93C46_16BIT)
MACHINE_CONFIG_END

MACHINE_CONFIG_START(s3_vga_device::device_add_mconfig)
Expand Down
5 changes: 3 additions & 2 deletions src/emu/emupal.cpp
View file
Original file line number Diff line number Diff line change
Expand Up @@ -17,8 +17,8 @@

DEFINE_DEVICE_TYPE(PALETTE, palette_device, "palette", "palette")

palette_device::palette_device(const machine_config &mconfig, const char *tag, device_t *owner, u32 clock)
: device_t(mconfig, PALETTE, tag, owner, clock),
palette_device::palette_device(const machine_config &mconfig, const char *tag, device_t *owner, u32 entries)
: device_t(mconfig, PALETTE, tag, owner, (uint32_t)0),
device_palette_interface(mconfig, *this),
m_entries(0),
m_indirect_entries(0),
Expand All @@ -32,6 +32,7 @@ palette_device::palette_device(const machine_config &mconfig, const char *tag, d
m_init(palette_init_delegate()),
m_raw_to_rgb(raw_to_rgb_converter())
{
set_entries(entries);
}


Expand Down
6 changes: 3 additions & 3 deletions src/emu/emupal.h
View file
Original file line number Diff line number Diff line change
Expand Up @@ -174,8 +174,8 @@
//**************************************************************************

#define MCFG_PALETTE_ADD(_tag, _entries) \
MCFG_DEVICE_ADD(_tag, PALETTE, 0) \
MCFG_PALETTE_ENTRIES(_entries)
MCFG_DEVICE_ADD(_tag, PALETTE, _entries)

#define MCFG_PALETTE_ADD_INIT_BLACK(_tag, _entries) \
MCFG_PALETTE_ADD(_tag, _entries) \
downcast<palette_device &>(*device).set_init(palette_init_delegate(FUNC(palette_device::palette_init_all_black), downcast<palette_device *>(device)));
Expand Down Expand Up @@ -364,7 +364,7 @@ class palette_device : public device_t, public device_palette_interface
{
public:
// construction/destruction
palette_device(const machine_config &mconfig, const char *tag, device_t *owner, u32 clock);
palette_device(const machine_config &mconfig, const char *tag, device_t *owner, u32 entries);

// configuration
template <typename Object> void set_init(Object &&init) { m_init = std::forward<Object>(init); }
Expand Down
10 changes: 8 additions & 2 deletions src/emu/screen.h
View file
Original file line number Diff line number Diff line change
Expand Up @@ -168,6 +168,12 @@ class screen_device : public device_t
public:
// construction/destruction
screen_device(const machine_config &mconfig, const char *tag, device_t *owner, u32 clock);

screen_device(const machine_config &mconfig, const char *tag, device_t *owner, screen_type_enum type)
: screen_device(mconfig, tag, owner, (u32)0)
{
set_type(type);
}
~screen_device();

// configuration readers
Expand Down Expand Up @@ -199,6 +205,7 @@ class screen_device : public device_t
}
void set_raw(const XTAL &xtal, u16 htotal, u16 hbend, u16 hbstart, u16 vtotal, u16 vbend, u16 vbstart) { set_raw(xtal.value(), htotal, hbend, hbstart, vtotal, vbend, vbstart); }
void set_refresh(attoseconds_t rate) { m_refresh = rate; }
void set_refresh_hz(attoseconds_t hz) { set_refresh(HZ_TO_ATTOSECONDS(hz)); }
void set_vblank_time(attoseconds_t time) { m_vblank = time; m_oldstyle_vblank_supplied = true; }
void set_size(u16 width, u16 height) { m_width = width; m_height = height; }
void set_visarea(s16 minx, s16 maxx, s16 miny, s16 maxy) { m_visarea.set(minx, maxx, miny, maxy); }
Expand Down Expand Up @@ -470,8 +477,7 @@ typedef device_type_iterator<screen_device> screen_device_iterator;
*/

#define MCFG_SCREEN_ADD(_tag, _type) \
MCFG_DEVICE_ADD(_tag, SCREEN, 0) \
MCFG_SCREEN_TYPE(_type)
MCFG_DEVICE_ADD(_tag, SCREEN, SCREEN_TYPE_##_type)

#define MCFG_SCREEN_ADD_MONOCHROME(_tag, _type, _color) \
MCFG_DEVICE_ADD(_tag, SCREEN, 0) \
Expand Down
2 changes: 1 addition & 1 deletion src/mame/audio/decobsmt.cpp
View file
Original file line number Diff line number Diff line change
Expand Up @@ -55,7 +55,7 @@ MACHINE_CONFIG_START(decobsmt_device::device_add_mconfig)

SPEAKER(config, "lspeaker").front_left();
SPEAKER(config, "rspeaker").front_right();
MCFG_BSMT2000_ADD(BSMT_TAG, XTAL(24'000'000))
MCFG_DEVICE_ADD(BSMT_TAG, BSMT2000, XTAL(24'000'000))
MCFG_DEVICE_ADDRESS_MAP(0, bsmt_map)
MCFG_BSMT2000_READY_CALLBACK(decobsmt_device, bsmt_ready_callback)
MCFG_SOUND_ROUTE(0, "lspeaker", 2.0)
Expand Down
2 changes: 1 addition & 1 deletion src/mame/drivers/20pacgal.cpp
View file
Original file line number Diff line number Diff line change
Expand Up @@ -400,7 +400,7 @@ MACHINE_CONFIG_START(_20pacgal_state::_20pacgal)
MCFG_DEVICE_PROGRAM_MAP(_20pacgal_map)
MCFG_DEVICE_IO_MAP(_20pacgal_io_map)

MCFG_EEPROM_SERIAL_93C46_8BIT_ADD("eeprom")
MCFG_DEVICE_ADD("eeprom", EEPROM_SERIAL_93C46_8BIT)

MCFG_WATCHDOG_ADD("watchdog")

Expand Down
2 changes: 1 addition & 1 deletion src/mame/drivers/39in1.cpp
View file
Original file line number Diff line number Diff line change
Expand Up @@ -1598,7 +1598,7 @@ MACHINE_CONFIG_START(_39in1_state::_39in1)

MCFG_PALETTE_ADD("palette", 256)

MCFG_EEPROM_SERIAL_93C66_ADD("eeprom")
MCFG_DEVICE_ADD("eeprom", EEPROM_SERIAL_93C66_16BIT)

SPEAKER(config, "lspeaker").front_left();
SPEAKER(config, "rspeaker").front_right();
Expand Down
Loading

1 comment on commit b66e57a

@Tafoid
Copy link
Contributor

@Tafoid Tafoid commented on b66e57a Jun 8, 2018

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

asylum, ataxx and clones - leland.cpp
eeprom. file being written incorrectly/differently than before causing changes in behavior or settings

In Asylum, different S/N number at title is observed
asylum-diff

In Ataxx, different characters are chosen for demonstration mode with different moves
ataxx-diff

Please sign in to comment.