Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

nintendo/punchout.cpp: sound not quite right #10628

Open
DJIncendration1 opened this issue Dec 3, 2022 · 3 comments
Open

nintendo/punchout.cpp: sound not quite right #10628

DJIncendration1 opened this issue Dec 3, 2022 · 3 comments

Comments

@DJIncendration1
Copy link

The sound and stereo positioning in a few games is a bit complicated and not quite right. I've noticed it most in Punch-Out, Super Punch-Out and Arm Wrestling.
Some may be hard to tell for the average listener, some are easy to tell. The biggest example that's easy to tell is when Dragon Chan does his kick in Super Punch-Out!! When he throws his kick, there is supposed to be a whoosh sound that gets rather loud. On Mame (including version 250), there is almost no sound at all. The sound that is there does not sound anything like it.
There are other issues that occur in both Punch-Out and Super Punch-Out. The voice is on the left side on Mame, but on the right side on original hardware. The counting speed is a bit fast on Mame, and the sound as the opponent falls is about the same as the NES knockdown sound.
In Arm Wrestling, the laugh when you don't get the money is fast and has a pause in the middle on Mame.
Here are videos captured from hardware from Punch-Out!! and Super Punch-Out!!.
https://www.youtube.com/watch?v=IEahziptyuo
https://www.youtube.com/watch?v=cNB0S5mdMnc
Here is a video of Arm Wrestling on an actual arcade machine (note that the man who made the video is talking while the laugh happens; I couldn't find a run captured directly from the hardware).) https://www.youtube.com/watch?v=HdVOXHcs4iI
Here are videos recorded from Mame (note: these videos were played on older versions, but the sound is the same on 250.)
https://www.youtube.com/watch?v=GpII2b-licY
https://www.youtube.com/watch?v=NkCICvuJh8E
https://www.youtube.com/watch?v=-BX-8iBpsfw
To reproduce these issues:
for the sound when the opponent is about to fall: just knock an opponent like Glass Joe down (usually a normal punch works better for reproducing this)
for Dragon Chan's kick sound: play through the game until Dragon Chan (2nd fight.) Dodge or do something until Dragon Chan does his kick.
to compare the voice: enter initials at the start of Punch-Out or Super Punch-Out.

@0kmg
Copy link
Contributor

0kmg commented Dec 3, 2022

These sorts of bug reports should be done at https://mametesters.org. In fact some of them are.

There are several issues here and they may be separate.

  • The stereo left/right issue is a trivial fix.
  • The missing Dragon Chan kick woosh seems like a problem with the VLM5030 emulation. This is a known bug: https://mametesters.org/view.php?id=959
  • Counting speed in Punch-Out is also a known issue: https://mametesters.org/view.php?id=8122
  • Arm Wrestling laugh speed issue is not reported yet, but probably related to Punch-Out counting speed (VLM5030 issue).
  • Which falling sound are you talking about? The high pitched twirling whistle sound as the opponent flies through the air? Isn't this sound supposed to be variable? It's not clear to me what I'm listening for here.

@DJIncendration1
Copy link
Author

DJIncendration1 commented Dec 3, 2022 via email

@0kmg
Copy link
Contributor

0kmg commented Dec 4, 2022

@DJIncendration1 Thanks for the follow up. I adjusted my left/right volume and can hear the "punch" sound on the other speaker when Dragon Chan kicks. So it's not so weird after all and I stand corrected.

Don't worry about the letters and numbers. Those are just chip names and there for whomever may be able to fix the bugs. I still can't tell what may be wrong with the falling sound, but I'll keep it on my radar since those are letters and numbers I've contributed to a tiny bit ;)

@angelosa angelosa changed the title sound not quite right in various games nintendo/punchout.cpp: sound not quite right Dec 4, 2022
@angelosa angelosa added driver device Deprecated label, use `<realm> device` labels instead. labels Dec 4, 2022
@angelosa angelosa added sound device and removed device Deprecated label, use `<realm> device` labels instead. labels May 7, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

3 participants