-
Notifications
You must be signed in to change notification settings - Fork 2k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
taito/taito_f3_v.cpp: line clip fixes, landmakr/quizhuhu palette fix #10920
Conversation
This comment was marked as abuse.
This comment was marked as abuse.
first mame contribution, please advise on possibly promoting quizhuhu to |
Promotion will happen once some testing has been made, there's no rush also because this comes after code freeze. |
re: the color kludge
but mnmm without information i don't have, i don't feel comfortable committing to those assumptions when it could be more misleading in the future. also the bits at x1000 kind of line up (extremely unlikely) |
src/mame/taito/taito_f3_v.cpp
Outdated
/* window intersection */ | ||
#define CALC_CLIP(p) \ | ||
clipl = std::max(sa_line->clip##p##_l[y], clipl); \ | ||
clipr = std::min(sa_line->clip##p##_r[y], clipr); | ||
|
||
/* window gap union */ | ||
#define CALC_CLIP_INV(p) \ | ||
clipl = std::min(sa_line->clip##p##_l[y], clipl); \ | ||
clipr = std::max(sa_line->clip##p##_r[y], clipr); |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Can you turn clipN_l and clipN_r into two-dimensional arrays so these can be turned into lambdas rather than needing token pasting like this?
also make taito f3 sprites respect all clip planes, fixes quizhuhu intro sprite
f854d31
to
83a4232
Compare
This has been merged, let the testing commence, as well as looking to get rid of the per-game hacks. |
Managed to take a look:
imho 1 is a liability for promoting the game (it's not just a cosmetic use like in |
yeah fair (3) is not a bug per the same ref https://youtu.be/5bXn5K5XdWU?t=6691 (2) after watching hours of recordings i couldn't find a ref, but the clip planes defined aren't related. the sprite may plausibly be clipped with alpha blending, though. calling this one another blending bug. |
fixes mt00950: landmakr: Winning message is missing.
fixes mt01014: quizhuhu: The question text is not displayed.
fixes mt02819: pbobble4 and clones: Victory screen not shown at end of match
fixes commandw map display
fixes quizhuhu pre-taito logo intro not visible
fixes landmakr ending slide display