Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

taito/taito_f3_v.cpp: eliminate game-specific palette hack [ywy, 12] #11788

Merged
merged 1 commit into from
Nov 29, 2023

Conversation

y-ack
Copy link
Contributor

@y-ack y-ack commented Nov 27, 2023

clean up after hack from #10920
mame combines palette base and pen color with addition, but the high planes in gfx overlap with lowest palette line bits in the color address (i.e. bitwise OR). account for this discrepancy in get_tile_info

Co-authored by: 12Me21 <12Me21.mc@gmail.com>
@cuavas
Copy link
Member

cuavas commented Nov 27, 2023

I’m reluctant to credit someone as “12” – it’s going to make it damn hard to track them down to ask a question or something in the future.

@y-ack
Copy link
Contributor Author

y-ack commented Nov 28, 2023

I’m reluctant to credit someone as “12” – it’s going to make it damn hard to track them down to ask a question or something in the future.

hi vas,
would it be acceptable to credit them as "twelve" ?
otherwise we can use "12Me21"

@cuavas cuavas merged commit 59ae6c1 into mamedev:master Nov 29, 2023
5 checks passed
Luigi30 pushed a commit to Luigi30/mame that referenced this pull request Dec 16, 2023
einstein95 pushed a commit to einstein95/mame that referenced this pull request Mar 2, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants