hash/pcecd.xml: QA notes #10956
Merged
hash/pcecd.xml: QA notes #10956
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Member
angelosa
commented
Mar 4, 2023
•
angelosa
commented
- nec/pce_cd.cpp: convert to logmacro, fix regression on redbook stop/repeat conditions, fix stop command for SUBQ command inquiry, fix redbook pregap for raw playback cases;
- nec/pce_cd.cpp: fix MT#07972
- nec/pce_cd.cpp: fix MT#07791
- nec/pce_cd.cpp: fix MT#05995 delay irq when start/end redbook commands are issued with play mode = 2, fixes macr2036, jleagt94, iganin, popful, eferajil;
- nec/pce_cd.cpp: fix longstanding regression with audio CD player not playing tracks at all;
- sound/cdda.cpp: add an actual write callback for audio playback end event, make emeraldd to actually repeat redbook on gameplay;
- sound/cdda.cpp: fix longstanding regression with get_channel_volume fn, rename it to get_channel_sample, make audio CD player metering to work again;
- nec/pce_cd.cpp: cancel redbook when audio start + play mode = 0 is issued, fixes ppersia sound when picking up sword
…ions, workaround MT#07972
…e issued, fixes macr2036 (MT #5995), jleagt94, iganin
…rename it to get_channel_sample
…sued, fixes ppersia sound when picking up sword
|
Ready for review. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.