Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

simpl156.cpp - add workram mirror for osman (needed for truck in final stage) #11207

Merged
merged 1 commit into from May 9, 2023
Merged

Conversation

ghost
Copy link

@ghost ghost commented May 9, 2023

@ghost ghost changed the title simpl156.cpp - add workram mirror for osman (needed for truck in fina… simpl156.cpp - add workram mirror for osman (needed for truck in final stage) May 9, 2023
@happppp
Copy link
Member

happppp commented May 9, 2023

It looks like that part is the same for all games, so it would make sense others have it.
How about this?:

void simpl156_state::common_map(address_map &map)
{
map.unmap_value_high();
map(0x000000, 0x07ffff).rom(); // rom (32-bit)
map(0x200000, 0x200003).portr("IN0");
map(0x201000, 0x201fff).ram().share("systemram").mirror(0x002000); // work ram (32-bit)
}

@ghost
Copy link
Author

ghost commented May 9, 2023

I'm not opposed to you refactoring it, I just fix the bug as reported here

@happppp
Copy link
Member

happppp commented May 9, 2023

It's a minor thing, but sure

@happppp happppp merged commit 065a5e6 into mamedev:master May 9, 2023
pauldevine pushed a commit to pauldevine/mame that referenced this pull request Jun 21, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant