konami/gticlub.cpp: Split class per hardware configuration, Use set_format for palette format/entries, Separate palette per Video board #11787
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…or palette format/entries, Separate palette per Video board
cam900
changed the title
cuavas
reviewed
Dec 3, 2023
Comment on lines
-477
to
+515
| map(0x74010000, 0x7401ffff).ram().w(FUNC(gticlub_state::paletteram32_w)).share(m_generic_paletteram_32); | ||
| m_cg_view[0](0x74010000, 0x7401ffff).ram().w(m_palette[0], FUNC(palette_device::write32)).share("palette1"); |
There was a problem hiding this comment.
Why did you put this into the view? Previously this was overlaying work RAM when the view was disabled, while now it is only active when the view is enabled. Is there a test case where this corrects or improves behaviour?
Comment on lines
-498
to
+540
| m_cg_view[1](0x74000000, 0x740000ff).rw(m_k001604[1], FUNC(k001604_device::reg_r), FUNC(k001604_device::reg_w)); | ||
| map(0x74010000, 0x7401ffff).ram().w(FUNC(gticlub_state::paletteram32_w)).share(m_generic_paletteram_32); | ||
| m_cg_view[0](0x74010000, 0x7401ffff).ram().w(m_palette[0], FUNC(palette_device::write32)).share("palette1"); | ||
| m_cg_view[0](0x74020000, 0x7403ffff).rw(m_k001604[0], FUNC(k001604_device::tile_r), FUNC(k001604_device::tile_w)); | ||
| m_cg_view[0](0x74040000, 0x7407ffff).rw(m_k001604[0], FUNC(k001604_device::char_r), FUNC(k001604_device::char_w)); | ||
| m_cg_view[1](0x74000000, 0x740000ff).rw(m_k001604[1], FUNC(k001604_device::reg_r), FUNC(k001604_device::reg_w)); | ||
| m_cg_view[1](0x74010000, 0x7401ffff).ram().w(m_palette[1], FUNC(palette_device::write32)).share("palette2"); |
There was a problem hiding this comment.
Same here – what’s the basis for only enabling palette 1 writes in view entry 0 now?
There was a problem hiding this comment.
because each video board has independent color RAM, and it fixes hangplt per-screen color palette entries.
Luigi30
pushed a commit
to Luigi30/mame
that referenced
this pull request
Dec 16, 2023
mamedev#11787) * Split up driver state class for different hardware configurations. * Use palette format utilities. * Use separate palettes for multiple video boards. * Only enable palette RAM access when video board is mapped over system RAM.
einstein95
pushed a commit
to einstein95/mame
that referenced
this pull request
Mar 2, 2024
mamedev#11787) * Split up driver state class for different hardware configurations. * Use palette format utilities. * Use separate palettes for multiple video boards. * Only enable palette RAM access when video board is mapped over system RAM.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.