atari/shuuz.cpp: add missing sprite-to-playfield shadow effect #11799
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…alette shift + 0x200, if the mo wins priority over the pf) Reference: https://farm5.staticflickr.com/4767/38913008994_3e2d2f6449_b.jpg
codefrog2002
changed the title
cuavas
reviewed
Nov 29, 2023
src/mame/atari/shuuz.cpp
Outdated
Comment on lines
187
to
188
| int mopf = 0; | ||
| if ((!(pf[x] & 0x80) && ((mo[x] & 0xc0) != 0xc0) && ((mo[x] & 0x0e) != 0x00) && !o13) || | ||
| ((pf[x] & 0x80) && ((mo[x] & 0xc0) == 0xc0) && ((mo[x] & 0x0e) != 0x00) && !o13)) | ||
| mopf = 1; | ||
| int mopf = ((!(pf[x] & 0x80) && ((mo[x] & 0xc0) != 0xc0) && !o13) || | ||
| ((pf[x] & 0x80) && ((mo[x] & 0xc0) == 0xc0) && !o13)); |
There was a problem hiding this comment.
The MO/PF signal here no longer matches the equations from the GAL shown above. Can you please link to the schematics for how this works?
There was a problem hiding this comment.
Sorry, I don’t have schematics evidence. My change is based on
- photo and video evidence of the game running which shows the shadow effect
- the game code doing the work (preparing the high palette) to support the shadows
- the game MO roms contain the sprite data to use the effect
- the game looks correct when the effect is enabled
Here’s an additional reference video
https://www.instagram.com/p/CsWoVKPMyw8/
There was a problem hiding this comment.
Annoyingly, there are no GAL dumps in the driver either, so it isn’t possible to check the actual equations.
Luigi30
pushed a commit
to Luigi30/mame
that referenced
this pull request
Dec 16, 2023
MO color 1 offsets playfield color by 0x200 if the playfield does not have priority.
einstein95
pushed a commit
to einstein95/mame
that referenced
this pull request
Mar 2, 2024
MO color 1 offsets playfield color by 0x200 if the playfield does not have priority.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Shuuz has been missing its sprite-shadow effect.
MO color 1 causes a PF palette shift + 0x200, if the mo has priority over the pf.
These shadows are visible at the feet of the round-card woman and the standing on-screen players.
Reference: https://farm5.staticflickr.com/4767/38913008994_3e2d2f6449_b.jpg
