Various Tecmo driver updates/cleanups #11886
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
shared/tecmo_spr.cpp: Use device_gfx_interface for gfx decode, Use callback for priority, Fix/Add notes, Minor cleanups comad/galspnbl.cpp, tecmo/spbactn.cpp, tecmo/tbowl.cpp, tecmo/wc90.cpp: Cleanup gfxdecode layouts tecmo/tecmo.cpp, tecmo/gaiden.cpp: Rename GFX ROM regions
cuavas
reviewed
Jan 2, 2024
src/mame/shared/tecmo_spr.cpp
Outdated
Comment on lines
79
to
86
| int attributes_word = 0; | ||
| int tilenumber_word = 1; | ||
| int colour_word = 2; | ||
| int yposition_word = 3; | ||
| int xposition_word = 4; | ||
| int const attributes_word = 0; | ||
| int const tilenumber_word = 1; | ||
| int const colour_word = 2; | ||
| int const yposition_word = 3; | ||
| int const xposition_word = 4; |
There was a problem hiding this comment.
You could make these constexpr and change them to SCREAMING_SNAKE_CASE as they’re constants (and sourceinc as well).
src/mame/shared/tecmo_spr.cpp
Outdated
| xmask = 512; | ||
| else | ||
| xmask = 256; | ||
|
|
||
| /* draw all sprites from front to back */ | ||
| bitmap_ind16* bitmap = &sprite_bitmap; |
There was a problem hiding this comment.
Does this local actually serve a purpose? Why not use sprite_bitmap directly, or rename it to bitmap?
src/mame/shared/tecmo_spr.cpp
Outdated
Comment on lines
107
to
114
| int frame = screen.frame_number() & 1; | ||
| if (frame==1) | ||
| uint8_t const frame = screen.frame_number() & 1; | ||
| if (frame == 1) | ||
| enabled = 0; |
There was a problem hiding this comment.
Since you’ve changed enabled to bool to reflect usage, you should probably change this to enabled = false; to match.
src/mame/tecmo/tecmo_v.cpp
Outdated
Comment on lines
81
to
88
| switch (pri) | ||
| { | ||
| default: | ||
| case 0x0: return 0; break; | ||
| case 0x1: return 0xf0; break; // obscured by text layer | ||
| case 0x2: return 0xf0|0xcc; break; // obscured by foreground | ||
| case 0x3: return 0xf0|0xcc|0xaa; break; // obscured by bg and fg | ||
| } |
There was a problem hiding this comment.
A break after a return is unreachable.
einstein95
pushed a commit
to einstein95/mame
that referenced
this pull request
Mar 2, 2024
* shared/tecmo_spr.cpp: Use device_gfx_interface to decode graphics ROMs, and callback for priority. * comad/galspnbl.cpp, tecmo/spbactn.cpp, tecmo/tbowl.cpp, tecmo/wc90.cpp: Adjusted graphics ROM loading so standard layouts can be used to decode tiles. * tecmo/tecmo.cpp, tecmo/gaiden.cpp: Use mnemonic names for graphics ROM regions.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
shared/tecmo_spr.cpp: Use device_gfx_interface for gfx decode, Use callback for priority, Fix/Add notes, Minor cleanups
comad/galspnbl.cpp, tecmo/spbactn.cpp, tecmo/tbowl.cpp, tecmo/wc90.cpp: Cleanup gfxdecode layouts
tecmo/tecmo.cpp, tecmo/gaiden.cpp: Rename GFX ROM regions