-
Notifications
You must be signed in to change notification settings - Fork 2k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Added LD-V1000 HLE device, placeholder SSI-263A HLE device, and promoted Thayer's Quest #11915
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks pretty reasonable.
In general, you’ve been a bit inconsistent with whether you put the explicit virtual
prefix qualifier on overridden virtual member functions in addition to the override
suffix qualifier. Yes, override
implies virtual
, but in MAME we generally explicitly include the virtual
qualifier as well.
Also, a non-dealbreaking thing – I noticed you used lowercase integer literal suffixes (e.g. 1u
). I tend to prefer uppercase (e.g. 1U
) due to the long and long long suffixes being potentially confused for 1 digits if they’re lowercase (1LL
is less likely to be confused with 111
than 1ll
at a glance). By extension I use uppercase for the unsigned and single precision literal suffixes as well.
…ted Thayer's Quest. (mamedev#11915) [Ryan Holtz] -cinematronics/thayers.cpp: Added CHD and promoted to working. [Ryan Holtz] * Fixed periodic IRQ hookup. * Fixed COP421 clock divisor. * Switched to LD-V1000 by default and removed LD-PR7820 support for now. * Switched to using logmacro and shorthand data types. * Adjusted IRQ triggering and acknowledgement according to schematics. -sound/ssi263hle.cpp: Added a temporary SSI-263 device which remaps SC-02 phonemes onto the SC-01's phoneme set. [Ryan Holtz] * SSI-263 skeleton extracted from cinematronics/thayers.cpp. -machine/ldv1000hle.cpp: Added an HLE version of the Pioneer LD-V1000 laserdisc player. [Ryan Holtz] -machine/laserdsc.h: Added a general-purpose parallel LaserDisc player interface, to have a common class parent for LD-PR7820. [Ryan Holtz] -sega/timetrv.cpp: Replaced timetrv2 LaserDisc image with a good capture. [Ryan Holtz, Matt Ownby, ld-decode Team] Systems promoted to working --------------------------- Thayer's Quest (set 1) [Ryan Holtz, Matt Ownby, ld-decode Team] Clones promoted to working -------------------------- Thayer's Quest (set 2) [Ryan Holtz, Matt Ownby, ld-decode Team]
Systems promoted to working
Thayer's Quest (set 1) [Ryan Holtz, Matt Ownby, ld-decode Team]
Clones promoted to working
Thayer's Quest (set 2) [Ryan Holtz, Matt Ownby, ld-decode Team]
-thayers: Added CHD and promoted to working. [Ryan Holtz]
-ldv1000hle: Added an HLE version of the Pioneer LD-V1000 laserdisc player. [Ryan Holtz]
-laserdsc: Added a general-purpose parallel laserdisc interface, to have a common class parent for LD-PR7820. [Ryan Holtz]
-ssi263hle: Added a temporary SSI-263 device which remaps SC-02 phonemes onto the SC-01's phoneme set. [Ryan Holtz]