-
Notifications
You must be signed in to change notification settings - Fork 2k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
irem/travrusa.cpp: Add support for Traverse USA and clones different PROMs setup [Victor Fernandez (City Game), Recreativas.org] #12001
Conversation
New working clone --------------------- MotoTour / Zippy Race (Tecfri license, set 2) [Victor Fernandez (City Game), Recreativas.org]
Is it just a case of the organisation being different which could be addressed during ROM loading? It would be good if someone could give this a look and see if it’s simple to get working before merging. |
If you load them like this it will work: |
So the question is, do we keep a clone for this PROM arrangement? It may be useful for people repairing systems if they encounter this variant. |
FWIW you could use a BIOS option to load one arrangement of PROMs or the other and avoid the need for a clone. |
Sounds good, will do that. Thx!! |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Should the alternate PROM arrangement be added to all the sets, or only to the ones it’s been seen on in the wild?
I've added it only to the sets I've found evidences of using both arrangements. Since it can be clearly seen on the PCB, it's easy to tell by looking at PCB pics. Thanks |
Have both bootleg versions really been seen with both PROM arrangements? That would be pretty surprising. |
Ah! You’re right, I’ve only seen this arrangement on original Irem/Tecfri/Williams. Should it be removed from bootleg sets? thx |
Yes, I wouldn’t add the option to the bootleg sets if they haven’t been seen with both arrangements. |
Done, thanks!! |
src/mame/irem/travrusa.cpp
Outdated
ROM_LOAD( "mb7052.3h2", 0x0220, 0x0100, CRC(76062638) SHA1(7378a26cf455d9d3df90929dc665870514c34b54) ) // sprite lookup table | ||
ROM_LOAD( "mmi6349.ij", 0x0000, 0x0200, CRC(c9724350) SHA1(1fac20cdc0a53d94e8f67b49d7dd71d1b9f1f7ef) ) // character palette - last $100 are unused | ||
ROM_LOAD( "tbp18s.2", 0x0200, 0x0020, CRC(a1130007) SHA1(9deb0eed75dd06e86f83c819a3393158be7c9dce) ) // sprite palette | ||
ROM_LOAD( "tbp24s10.3", 0x0220, 0x0100, CRC(76062638) SHA1(7378a26cf455d9d3df90929dc665870514c34b54) ) // sprite lookup table |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Why the change to the labels here? This set previously had different labels to the parent and the other bootleg. Were they found to be incorrect?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
My bad. Restored the original labels. Sorry.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Please look at the overall diff. You’ve “restored” the PROM labels on the wrong bootleg. Now travrusab
and travrusab2
have their PROM labels swapped with each other.
Ah! Yes, comitted before finished editing by mistake, but I saw the error, it's OK now |
In the future, please check your changes carefully. It’s far too easy for errors to get in like this, and noticing/fixing them after the fact is always far more difficult. |
Will do. Thanks a lot!!!! |
…averse USA and MotoTour. (mamedev#12001) [Victor Fernandez (City Game), Recreativas.org]
…averse USA and MotoTour. (mamedev#12001) [Victor Fernandez (City Game), Recreativas.org]
Add support for Traverse USA and clones different PROMs setup with two 256x4 character palette PROMs instead of only 256x8 one (same contents on both setups).
Confirmed to exist on Traverse USA, MotoTour and MotoRace USA.