Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

irem/travrusa.cpp: Add support for Traverse USA and clones different PROMs setup [Victor Fernandez (City Game), Recreativas.org] #12001

Merged
merged 8 commits into from
Feb 19, 2024

Conversation

clawgrip
Copy link
Contributor

@clawgrip clawgrip commented Feb 2, 2024

Add support for Traverse USA and clones different PROMs setup with two 256x4 character palette PROMs instead of only 256x8 one (same contents on both setups).

Confirmed to exist on Traverse USA, MotoTour and MotoRace USA.

New working clone
---------------------
MotoTour / Zippy Race (Tecfri license, set 2) [Victor Fernandez (City Game), Recreativas.org]
@cuavas
Copy link
Member

cuavas commented Feb 3, 2024

Is it just a case of the organisation being different which could be addressed during ROM loading? It would be good if someone could give this a look and see if it’s simple to get working before merging.

@Osso13
Copy link
Member

Osso13 commented Feb 4, 2024

If you load them like this it will work:
ROM_REGION( 0x0320, "proms", 0 )
ROM_LOAD_NIB_HIGH( "prom.h1 ", 0x0000, 0x0100, CRC(2f98ddf0) SHA1(e90c3cebe3e788cbf8e23030f58a1153564207e2) ) // On tiles PCB
ROM_LOAD_NIB_LOW( "prom.f1 ", 0x0000, 0x0100, CRC(adea1297) SHA1(8f365cc15cc3c26b388ba957d7cf3752584d5475) ) // On tiles PCB
ROM_LOAD( "prom1.f1", 0x0200, 0x0020, CRC(a1130007) SHA1(9deb0eed75dd06e86f83c819a3393158be7c9dce) ) // On sprites PCB
ROM_LOAD( "prom2.h2", 0x0220, 0x0100, CRC(76062638) SHA1(7378a26cf455d9d3df90929dc665870514c34b54) ) // On sprites PCB
That said, they have the exact same content.

@cuavas
Copy link
Member

cuavas commented Feb 4, 2024

That said, they have the exact same content.

So the question is, do we keep a clone for this PROM arrangement? It may be useful for people repairing systems if they encounter this variant.

@cuavas
Copy link
Member

cuavas commented Feb 4, 2024

FWIW you could use a BIOS option to load one arrangement of PROMs or the other and avoid the need for a clone.

@clawgrip
Copy link
Contributor Author

clawgrip commented Feb 5, 2024

FWIW you could use a BIOS option to load one arrangement of PROMs or the other and avoid the need for a clone.

Sounds good, will do that. Thx!!

@clawgrip clawgrip changed the title irem/travrusa.cpp: Add a MotoTour set with different PROMs setup irem/travrusa.cpp: Add support for Traverse USA and clones different PROMs setup Feb 5, 2024
@clawgrip clawgrip changed the title irem/travrusa.cpp: Add support for Traverse USA and clones different PROMs setup irem/travrusa.cpp: Add support for Traverse USA and clones different PROMs setup [Victor Fernandez (City Game), Recreativas.org] Feb 5, 2024
Copy link
Member

@cuavas cuavas left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Should the alternate PROM arrangement be added to all the sets, or only to the ones it’s been seen on in the wild?

@clawgrip
Copy link
Contributor Author

Should the alternate PROM arrangement be added to all the sets, or only to the ones it’s been seen on in the wild?

I've added it only to the sets I've found evidences of using both arrangements. Since it can be clearly seen on the PCB, it's easy to tell by looking at PCB pics.

Thanks

@cuavas
Copy link
Member

cuavas commented Feb 17, 2024

Have both bootleg versions really been seen with both PROM arrangements? That would be pretty surprising.

@clawgrip
Copy link
Contributor Author

Have both bootleg versions really been seen with both PROM arrangements? That would be pretty surprising.

Ah! You’re right, I’ve only seen this arrangement on original Irem/Tecfri/Williams.

Should it be removed from bootleg sets?

thx

@cuavas
Copy link
Member

cuavas commented Feb 19, 2024

Have both bootleg versions really been seen with both PROM arrangements? That would be pretty surprising.

Ah! You’re right, I’ve only seen this arrangement on original Irem/Tecfri/Williams.

Should it be removed from bootleg sets?

thx

Yes, I wouldn’t add the option to the bootleg sets if they haven’t been seen with both arrangements.

@clawgrip
Copy link
Contributor Author

Yes, I wouldn’t add the option to the bootleg sets if they haven’t been seen with both arrangements.

Done, thanks!!

ROM_LOAD( "mb7052.3h2", 0x0220, 0x0100, CRC(76062638) SHA1(7378a26cf455d9d3df90929dc665870514c34b54) ) // sprite lookup table
ROM_LOAD( "mmi6349.ij", 0x0000, 0x0200, CRC(c9724350) SHA1(1fac20cdc0a53d94e8f67b49d7dd71d1b9f1f7ef) ) // character palette - last $100 are unused
ROM_LOAD( "tbp18s.2", 0x0200, 0x0020, CRC(a1130007) SHA1(9deb0eed75dd06e86f83c819a3393158be7c9dce) ) // sprite palette
ROM_LOAD( "tbp24s10.3", 0x0220, 0x0100, CRC(76062638) SHA1(7378a26cf455d9d3df90929dc665870514c34b54) ) // sprite lookup table
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Why the change to the labels here? This set previously had different labels to the parent and the other bootleg. Were they found to be incorrect?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

My bad. Restored the original labels. Sorry.

Copy link
Member

@cuavas cuavas left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please look at the overall diff. You’ve “restored” the PROM labels on the wrong bootleg. Now travrusab and travrusab2 have their PROM labels swapped with each other.

@clawgrip
Copy link
Contributor Author

Please look at the overall diff. You’ve “restored” the PROM labels on the wrong bootleg. Now travrusab and travrusab2 have their PROM labels swapped with each other.

Ah! Yes, comitted before finished editing by mistake, but I saw the error, it's OK now

@cuavas
Copy link
Member

cuavas commented Feb 19, 2024

In the future, please check your changes carefully. It’s far too easy for errors to get in like this, and noticing/fixing them after the fact is always far more difficult.

@cuavas cuavas merged commit aa00a66 into mamedev:master Feb 19, 2024
5 checks passed
@clawgrip
Copy link
Contributor Author

In the future, please check your changes carefully. It’s far too easy for errors to get in like this, and noticing/fixing them after the fact is always far more difficult.

Will do. Thanks a lot!!!!

@clawgrip clawgrip deleted the patch-14 branch February 19, 2024 17:25
Mokona pushed a commit to Mokona/mame that referenced this pull request Feb 28, 2024
…averse USA and MotoTour. (mamedev#12001) [Victor Fernandez (City Game), Recreativas.org]
stonedDiscord pushed a commit to stonedDiscord/mame that referenced this pull request Apr 8, 2024
…averse USA and MotoTour. (mamedev#12001) [Victor Fernandez (City Game), Recreativas.org]
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants