es5510, taito_en Updates #3284
Merged
es5510, taito_en Updates #3284
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Add notes Fix dram read/write Convert gpr, instr, dram into std::unique_ptr Add save states Minor cleanup taito_en.* Updates : Add notes Move imperfect_features() into es5510.h Verify ESP Input clock/output channels(from GunBuster Schematics, same in other PCBs?) Add m_bankmask instead runtime tag lookups
|
cam900,thank you for your good work on taito_en sound device,hope we can get the perfect ES5510 ESP emulation |
cuavas
requested changes
Mar 1, 2018
src/devices/cpu/es5510/es5510.h
Outdated
| @@ -12,9 +12,14 @@ | |||
|
|
|||
| #pragma once | |||
|
|
|||
| // TODO : Not verified | |||
| #define DRAM_SIZE (1<<20) | |||
| #define DRAM_MASK (DRAM_SIZE-1) | |||
There was a problem hiding this comment.
Please don't add constants like this at global scope, and don't use #define preprocessor macros. Make them members of the state class, using either static constexpr or enum.
cuavas
reviewed
Mar 1, 2018
src/devices/cpu/es5510/es5510.h
Outdated
| class es5510_device : public cpu_device { | ||
| public: | ||
| // TODO : Not verified | ||
| static constexpr DRAM_SIZE (1<<20); | ||
| static constexpr DRAM_MASK (DRAM_SIZE-1); |
There was a problem hiding this comment.
You need to test these changes - this requires you to supply a type and use the = sign.
|
cam900，once the ES5510 emulation issue can get fixed,if considered remove the imperfect sound flag for taito_en sound device? |
…Because it has not perfectly emulated esqasr.cpp, esqkt.cpp : Add esqpump for es5510 interface taito_en.h : Restore imperfect_features Because sound emulation has still not perfect
…e current ES5510 core still has emulation issue
…d::unique_ptr if used
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
es5510.* Updates :
Add notes
Fix dram read/write
Convert gpr, instr, dram into std::unique_ptr
Add save states
Minor cleanup
taito_en.* Updates :
Add notes
Move imperfect_features() into es5510.h, Because most sound emulation issue is shared at ES5510 emulation issue.
Verify ESP Input clock/output channels(from GunBuster Schematics, same in other PCBs?)
Add m_bankmask instead runtime tag lookups