Namco custom chip improvements. #6589
Conversation
m_nf is basically the IF flag. It should be set when the int line is active (when its low). Only trigger an int when the line was previously high.
Three control bits are used for the clock divider.
Previously, this was using high-level emulation. This had some game-specific hacks.
With the better Namco custom chip emulation, this doesn't seem to be required anymore.
| m_latch->q_out_cb<1>().set("51xx", FUNC(namco_51xx_device::reset)); | ||
| m_latch->q_out_cb<1>().set("52xx", FUNC(namco_52xx_device::reset)); | ||
| m_latch->q_out_cb<1>().set("53xx", FUNC(namco_53xx_device::reset)); | ||
| m_latch->q_out_cb<1>().set("54xx", FUNC(namco_54xx_device::reset)); |
There was a problem hiding this comment.
The first three of these aren’t going to do anything useful – you need to use .append if you want to chain additional handlers.
There was a problem hiding this comment.
Ah good catch. Fixed in #6595.
|
We have some regression and some oddness which may just be minor timing changes battles - galaga.cpp
-- Only 2 detected snapshot diffs between before/after. gatsbee - galaga.cpp polepos - polepos.cpp -- A number of wavdata comparisons show a different hash. These are likely slight timing issues but only certain machines triggered so I'm listing them below,
bosco - galaga.cpp - (1920044) - d825f030 | (1920044) - ad3627d8 HASH |
|
Interesting. I'll look into this tomorrow when I'm home again.
…On Sat, Apr 25, 2020, 12:33 PM Scott Stone ***@***.***> wrote:
We have some regression and some oddness which may just be minor timing
changes
Testing from your #6595 <#6595> -
Using "-str 10 -video none -sound none -nothrottle -watchdog 25" with
cleared nvram/cfg/ini
battles - galaga.cpp
Exception at start of emulation
Exception at EIP=00000000007e2c78 (ioport_port::read()+0x0018): ACCESS
VIOLATION
Stack crawl:
0000000000229110: 00000000007e2c78 (ioport_port::read()+0x0018)
00000000002291f0: 00000000004370a1
(battles_state::input_port_r(address_space&, unsigned int, unsigned
char)+0x0051)
0000000000229220: 00000000010058d6 (handler_entry_read_delegate<0, 0, 0,
emu::device_delegate<unsigned char (address_space&, unsigned int, unsigned
char)> >::read(unsigned int, unsigned char)+0x0026)
0000000000229250: 00000000010c5d2e (handler_entry_read_dispatch<14, 0, 0,
0>::read(unsigned int, unsigned char)+0x001e)
0000000000229280: 000000000111759f (handler_entry_read_dispatch<16, 0, 0,
0>::read(unsigned int, unsigned char)+0x001f)
00000000002292b0: 0000000000df86e1 (address_space_specific<0, 0,
(endianness_t)0>::read_byte(unsigned int)+0x0021)
0000000000229340: 000000000065ee2e (z80_device::execute_run()+0x2eae)
--
Only 2 detected snapshot diffs between before/after.
gatsbee - galaga.cpp
[image: gatsbee-diff]
<https://user-images.githubusercontent.com/9075896/80288879-f6e65600-8708-11ea-86dd-949c7ad1119f.png>
polepos - polepos.cpp
[image: polepos-diff]
<https://user-images.githubusercontent.com/9075896/80288882-f8b01980-8708-11ea-867a-c8a7273506af.png>
--
A number of wavdata comparisons show a different hash. These are likely
slight timing issues but only certain machines triggered so I'm listing
them below,
- machine - driver (size before) - hash before | (size after) - hash
after
bosco - galaga.cpp - (1920044) - d825f030 | (1920044) - ad3627d8 HASH
boscomd - galaga.cpp - (1920044) - d825f030 | (1920044) - ad3627d8 HASH
boscomdo - galaga.cpp - (1920044) - d825f030 | (1920044) - ad3627d8 HASH
boscoo - galaga.cpp - (1920044) - d825f030 | (1920044) - ad3627d8 HASH
boscoo2 - galaga.cpp - (1920044) - d825f030 | (1920044) - ad3627d8 HASH
gatsbee - galaga.cpp - (1920044) - 018cc14d | (1920044) - 36eaedb6 HASH
polepos - polepos.cpp - (1920044) - b35261bf | (1920044) - cbb817f9 HASH
polepos2 - polepos.cpp - (1920044) - 7e7cb8c6 | (1920044) - 88af1da8 HASH
polepos2a - polepos.cpp - (1920044) - f531c434 | (1920044) - 3d86c41e HASH
polepos2b - polepos.cpp - (1920044) - eabcb171 | (1920044) - 66d76201 HASH
poleposa1 - polepos.cpp - (1920044) - 86cfafdf | (1920044) - 904464f1 HASH
poleposa2 - polepos.cpp - (1920044) - 86cfafdf | (1920044) - 904464f1 HASH
poleposj - polepos.cpp - (1920044) - d55d98cd | (1920044) - d1c48775 HASH
ppspeed - polepos.cpp - (1920044) - d55d98cd | (1920044) - d1c48775 HASH
topracer - polepos.cpp - (1920044) - d55d98cd | (1920044) - d1c48775 HASH
topracera - polepos.cpp - (1920044) - d55d98cd | (1920044) - d1c48775 HASH
—
You are receiving this because you authored the thread.
Reply to this email directly, view it on GitHub
<#6589 (comment)>, or
unsubscribe
<https://github.com/notifications/unsubscribe-auth/ABWSMCZS5D22PLXRDE6GUZDROM3GZANCNFSM4MQUPA7A>
.
|
|
I've fixed the crash in battles, but there's another regression - no sound. Please fix at your convenience. |
* Wire up reset lines on namco custom chips. * namco51: emulate via low level cpu Previously, this was using high-level emulation. This had some game-specific hacks. * namco06: Emulate the NMI and chip select lines more accurately. Three control bits are used for the clock divider. * mb88xx: fix interrupt handling. m_nf is basically the IF flag. It should be set when the int line is active (when its low). Only trigger an int when the line was previously high. * namco custom chips: remove debug logging * galaga, polepos: Remove quantum hacks. With the better Namco custom chip emulation, this doesn't seem to be required anymore.
|
I've fixed the battles sound in #6598.
gallag was also broken, and that fixes that.
I think the graphic and sound changes are correct. The timing issues I
fixed likely made the slight changes. I think the same is true for the
sound changes. It would be interesting to compare to a real board though.
…On Sat, Apr 25, 2020 at 8:05 PM Robert ***@***.***> wrote:
I've fixed the crash in battles, but there's another regression - no
sound. Please fix at your convenience.
—
You are receiving this because you authored the thread.
Reply to this email directly, view it on GitHub
<#6589 (comment)>, or
unsubscribe
<https://github.com/notifications/unsubscribe-auth/ABWSMC7LFQM2WHEZUPCXUSDROOQHDANCNFSM4MQUPA7A>
.
|
Some improvement to the namco custom chips. I've tested the games fairly thoroughly, and didn't find any breakages.