Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

New working clones #6697

Merged
merged 5 commits into from
May 14, 2020
Merged

New working clones #6697

merged 5 commits into from
May 14, 2020

Conversation

clawgrip
Copy link
Contributor


Hot Blocks - Tetrix II (set 2) [Victor Fernandez (City Game), ClawGrip]
Hot Blocks - Tetrix II (set 3) [jordigahan, ClawGrip]

------------------
Hot Blocks - Tetrix II (set 2) [jordigahan, ClawGrip]
Hot Blocks - Tetrix II (set 3) [Victor Fernandez (City Game), ClawGrip]

(nw) Also, the driver is now using the right devices (V20 instead of 8088 and a 8919 instead of a 2149, etc.) and adding missing PLDs placeholders.
void hotblock_state::hotblock(machine_config &config)
{
/* basic machine hardware */
I8088(config, m_maincpu, 24_MHz_XTAL / 3); // Unknown clock
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The PCB info that was at the top of the driver reported a P8088-1 as the CPU.
I'm not sure completely removing this info from the driver is the best course of action.
Same goes for changing the 24C04 to 24C02 and the YM2149 to AY8910.
Isn't it possible this game ran on two different PCB revision with different (mostly compatible) components? If yes, shouldn't this be documented?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yes, I asked @davidhaywood about it and he did not remember having a PCB pic or something. I've located five different PCBs and all of them had a NEC V20.
About the 24C04, it was probably used on some boards, but wasting half the size, as it's just using 0x0100 bits, so I'd say using a 24C02 is the right choice...
Anyway, you're right, this changes should be documented. I'll add another commit on a few minutes.
Thx!

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks, I believe this is a pic of the dumped PCB, but it was done in the mid 2000 and the definition isn't good enough:

https://imgur.com/a/ISVU2tD

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I'd say the CPU has its surface scratched out...

@Osso13 Osso13 merged commit 7061c23 into mamedev:master May 14, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants