-
Notifications
You must be signed in to change notification settings - Fork 2k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
New working clones #6697
Merged
Merged
New working clones #6697
Changes from all commits
Commits
Show all changes
5 commits
Select commit
Hold shift + click to select a range
6b08495
New working clones
clawgrip 6136b77
Add 'hotblocka' and 'hotblockb' (nw)
clawgrip d6c69b6
Make the newer set the parent one, and the older the latest set (nw)
clawgrip 6d2a885
Let the old parent as it was, just the oldest clone as the last set (…
clawgrip df671a7
Add notes about different but compatible device types that can be fou…
clawgrip File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The PCB info that was at the top of the driver reported a P8088-1 as the CPU.
I'm not sure completely removing this info from the driver is the best course of action.
Same goes for changing the 24C04 to 24C02 and the YM2149 to AY8910.
Isn't it possible this game ran on two different PCB revision with different (mostly compatible) components? If yes, shouldn't this be documented?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Yes, I asked @davidhaywood about it and he did not remember having a PCB pic or something. I've located five different PCBs and all of them had a NEC V20.
About the 24C04, it was probably used on some boards, but wasting half the size, as it's just using 0x0100 bits, so I'd say using a 24C02 is the right choice...
Anyway, you're right, this changes should be documented. I'll add another commit on a few minutes.
Thx!
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks, I believe this is a pic of the dumped PCB, but it was done in the mid 2000 and the definition isn't good enough:
https://imgur.com/a/ISVU2tD
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I'd say the CPU has its surface scratched out...