firebeat: Use CHDs with proper subchannel data for Keyboardmania 1st/2nd #7873
Conversation
|
|
||
| DISK_REGION( "ata:1:cdrom" ) // audio CD-ROM | ||
| DISK_IMAGE_READONLY( "gu974-ka a02", 1, SHA1(e66930f965b1aa1a681ab696302a04958dc8a334) ) // identical to jaa02 image |
There was a problem hiding this comment.
The .img is identical but the subchannel data isn't.
> sha1sum -b GQ974-JAA02/GQ974-JA\ A02.img GQ974-JAA02/GQ974-JA\ A02.sub GU974-KAA02/GU974-KA\ A02.img GU974-KAA02/GU974-KA\ A02.sub
cc7d90d902c0e5553988149bc57a05c3cac472b5 *GQ974-JAA02/GQ974-JA A02.img
7f3a2f6a19bdc01bee2e090e696b3c3c6b6b2056 *GQ974-JAA02/GQ974-JA A02.sub
cc7d90d902c0e5553988149bc57a05c3cac472b5 *GU974-KAA02/GU974-KA A02.img
ec9c52ebcd1a769748628a4ea6d334e93cbed9ae *GU974-KAA02/GU974-KA A02.sub
There was a problem hiding this comment.
subchannel data tends to be less repeatable on multiple reads, so it's possible the discs are still identical, just you'd get slightly different subchannel data each time, it's one of the issues with CD dumping (and why in some cases, it isn't included unless it's needed for protections etc.)
There was a problem hiding this comment.
That’s why we have things like cdparanoia for dealing with it. What tools were actually used to produce the dumps in the first place?
There was a problem hiding this comment.
afaik for subchannel data even tools like cdparanoia don't really help, there are long and heated debates on the subject to the point people have literally just given up, because it became a blocking issue.
This is related to the recent #7818.
The CHDs included in that PR didn't include the subchannel data so I got the original data from Jennifer Taylor and rebuilt them using bin/toc files extracted with cdrdao.
This fixes 2 second audio offset issues in Keyboardmania 2nd Mix.
There is still a 2 second audio offset issue in Keyboardmania 1st Mix/Keyboardheaven which I believe could possibly be due to an incomplete implementation of mixed mode LBA offsets (see: #7822).
All dumps are to be credited to Jennifer Taylor.