Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

firebeat: Use CHDs with proper subchannel data for Keyboardmania 1st/2nd #7873

Merged
merged 1 commit into from Mar 19, 2021
Merged

firebeat: Use CHDs with proper subchannel data for Keyboardmania 1st/2nd #7873

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Jump to
Jump to file
Failed to load files.
Diff view
Diff view
12 changes: 6 additions & 6 deletions src/mame/drivers/firebeat.cpp
View file
Open in desktop
Expand Up @@ -2341,10 +2341,10 @@ ROM_START( kbm )
ROM_LOAD("gq974", 0x00, 0xc8, CRC(65e4886a) SHA1(afba0315f2532599c51e232f734c538c4d108d73))

DISK_REGION( "ata:0:cdrom" ) // program CD-ROM
DISK_IMAGE_READONLY( "gq974-ja c01", 0, SHA1(46b766b5ed75de4139df369b414692919de244c7) )
DISK_IMAGE_READONLY( "gq974-ja c01", 0, SHA1(975a4a59f842b8a7edad79b307e489cc88bef24d) )

DISK_REGION( "ata:1:cdrom" ) // audio CD-ROM
DISK_IMAGE_READONLY( "gq974-ja a02", 1, SHA1(e66930f965b1aa1a681ab696302a04958dc8a334) )
DISK_IMAGE_READONLY( "gq974-ja a02", 1, SHA1(80086676c00c9ca06ec14e305ea4523b6576e47f) )
ROM_END

ROM_START( kbh )
Expand All @@ -2355,10 +2355,10 @@ ROM_START( kbh )
ROM_LOAD("gu974", 0x00, 0xc8, CRC(748b8476) SHA1(5d507fd46235c4315ad32599ce87aa4e06642eb5))

DISK_REGION( "ata:0:cdrom" ) // program CD-ROM
DISK_IMAGE_READONLY( "gu974-ka a01", 0, SHA1(af4e8182f6a984895d9a9a00bbfb6c65fb7b4738) )
DISK_IMAGE_READONLY( "gu974-ka a01", 0, SHA1(07d3d6abcb13b2c2a556f2eed7e89e3d11febf1b) )

DISK_REGION( "ata:1:cdrom" ) // audio CD-ROM
DISK_IMAGE_READONLY( "gu974-ka a02", 1, SHA1(e66930f965b1aa1a681ab696302a04958dc8a334) ) // identical to jaa02 image
Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The .img is identical but the subchannel data isn't.

> sha1sum -b GQ974-JAA02/GQ974-JA\ A02.img GQ974-JAA02/GQ974-JA\ A02.sub GU974-KAA02/GU974-KA\ A02.img GU974-KAA02/GU974-KA\ A02.sub 
cc7d90d902c0e5553988149bc57a05c3cac472b5 *GQ974-JAA02/GQ974-JA A02.img
7f3a2f6a19bdc01bee2e090e696b3c3c6b6b2056 *GQ974-JAA02/GQ974-JA A02.sub
cc7d90d902c0e5553988149bc57a05c3cac472b5 *GU974-KAA02/GU974-KA A02.img
ec9c52ebcd1a769748628a4ea6d334e93cbed9ae *GU974-KAA02/GU974-KA A02.sub

Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

subchannel data tends to be less repeatable on multiple reads, so it's possible the discs are still identical, just you'd get slightly different subchannel data each time, it's one of the issues with CD dumping (and why in some cases, it isn't included unless it's needed for protections etc.)

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

That’s why we have things like cdparanoia for dealing with it. What tools were actually used to produce the dumps in the first place?

Copy link

@ghost ghost Mar 19, 2021 •
edited by ghost

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

afaik for subchannel data even tools like cdparanoia don't really help, there are long and heated debates on the subject to the point people have literally just given up, because it became a blocking issue.

DISK_IMAGE_READONLY( "gu974-ka a02", 1, SHA1(9e358b0551b650a432e685ec82d3df2433e2aac3) )
ROM_END

ROM_START( kbm2nd )
Expand All @@ -2369,10 +2369,10 @@ ROM_START( kbm2nd )
ROM_LOAD("gca01ja_gca01aa", 0x00, 0xc8, CRC(27f977cf) SHA1(14739cb4edfc3c4453673d59f2bd0442eab71d6a))

DISK_REGION( "ata:0:cdrom" ) // program CD-ROM
DISK_IMAGE_READONLY( "a01 ja a01", 0, SHA1(0aabc0c03f7ae7e7633bf6056de833ace68f9163) )
DISK_IMAGE_READONLY( "a01 ja a01", 0, SHA1(6a661dd737c83130febe771402a159859afeffba) )

DISK_REGION( "ata:1:cdrom" ) // audio CD-ROM
DISK_IMAGE_READONLY( "a01 ja a02", 1, SHA1(4d62f6ecfbf5ab0b014feb7b01014cba440c87f8) )
DISK_IMAGE_READONLY( "a01 ja a02", 1, SHA1(e1ffc0bd4ea169951ed9ceaf090dbb1511a46601) )
ROM_END

ROM_START( kbm3rd )
Expand Down