lwriter.cpp: Reimplement the 0x600000-0x7fffff range to bitwise-OR on write. #8315
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
cuavas
requested changes
Jul 19, 2021
There was a problem hiding this comment.
Please note the affected driver in your commit messages and PR titles – a person reading commit history shouldn’t need to dig into diffs to get context.
Also, while you’re doing this, you could change m_dram_ptr to a required_shared_ptr<uint16_t> and change m_rom_ptr to a required_region_ptr<uint16_t> – this makes the code a bit clearer and helps avoid certain common bugs.
jrmuizel
changed the title
jrmuizel
changed the title
… write. This appears to be the desired effect of the code using this range. It fixes the rasterization of the '5' glyph in the test page and avoids the "Fatal system error @ 0x2a8416" buffer overflow in glyph the cache when writting out the last byte of the bitmap because it ends up or'ing with zero instead of overwritting with zero. Fixes mamedev#8309
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This appears to be the desired effect of the code using this range.
It fixes the rasterization of the '5' glyph in the test page and avoids
the "Fatal system error @ 0x2a8416" buffer overflow in glyph the cache
when writting out the last byte of the bitmap because it ends up or'ing
with zero instead of overwritting with zero.
Fixes #8309