bus/nes: Improved support for various VRC clone boards. #8687
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- Expanded VRC4 CHR bank regs to 9-bit. This functionality is verified on Konami VRC4 hardware as well but is only used by clones (World Hero here). - Removed board for World Hero. Its VRC4 clone chip is under a glop top but is thought to be identical to Konami's. - Reimplemented TF1201 (Lethal Weapon) as a VRC4 subclass. Its clone chip is only known to differ by the IRQ reload bit, which it ignores. - Reimplemented Shui Guan Pipe as a VRC4 subclass. Its clone chip has different PRG banking but is otherwise standard. Software list items promoted to working (nes.xml) --------------------------------------- Gimmick! (Asia, pirate) Lethal Weapon (China) World Hero (Asia) World Hero (Asia, alt)
|
The change to the underlying Konami code affects VRC4/6/7, though there shouldn't be any problems since these (CHR) bank sizes are variable anyway and I've just added one bit. Still I did a brief spot check on a handful of the dozen or so Konami games using these chips just to be safe. Oh, and I moved these new implementations to a new file as I'm anticipating adding quite a few VRC clone boards. I just settled on doing very broken existing softlist entries for this first pass. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Software list items promoted to working (nes.xml)
Gimmick! (Asia, pirate)
Lethal Weapon (China)
World Hero (Asia)
World Hero (Asia, alt)