Get Kurzweil K2000 skeleton driver to boot. #9545
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
angelosa
reviewed
Apr 11, 2022
| map(0x7e0000, 0x7e0001).w(FUNC(k2000_state::swap_bit_ctrl_w)); | ||
|
|
||
| // Some sort of hardware mapping - initial firmware boot expects a 4 at $78000B | ||
| map(0x780000, 0x78FFFF).ram(); |
There was a problem hiding this comment.
address_map mixes up UPPERCASE and lowercase in mapping. Please use latter only.
angelosa
reviewed
Apr 11, 2022
|
|
||
| // SROM - Setup ROM? | ||
| uint32 srom_base = 0x280000; | ||
| map(srom_base, srom_base + 0x40000 - 1).rom().region("maincpu", 0x100000); |
There was a problem hiding this comment.
imho calculations and notes aren't a thing for mapping. They should be as simple as possible so that the next guy debugging this doesn't struggle in understand what a given access should map to.
For notes, my suggestion is that if you need more than single liners then shouldn't be inside address_map at all but moved to a separate notes section, either near the relevant actual implementation detail or in file header. Also cfr. the floppy section just below this, where you repeat the mapping note twice.
wilbertpol
pushed a commit
to wilbertpol/mame
that referenced
this pull request
Apr 22, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
(Apologies if the format or content of this PR deviates from MAME standards - this is my first pull request to the project and I tried to keep things roughly similar to what I've seen in existing MAME code.)
This PR gets the MAME driver for the Kurzweil K2000 to complete its boot sequence and land on the main UI:
I/O is still not working (no MIDI input), audio output is still not working, etc. Many comments have been left in the code to describe some of the reverse-engineering work undertaken to get things working so far. But it boots!
(cc @d235j, @Lord-Nightmare)