Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Make sure "unit" test run fast or move to integration or stress folder #1044

Closed
qc00 opened this issue Nov 8, 2023 · 0 comments
Closed

Make sure "unit" test run fast or move to integration or stress folder #1044

qc00 opened this issue Nov 8, 2023 · 0 comments
Labels

Comments

@qc00
Copy link
Contributor

qc00 commented Nov 8, 2023

Since #744, most integration and stress tests will run with multiple storages, and #1014 will make them run against even more storages.

However, this was applied to a few unit tests, which makes them take much more time. The unit job now takes ~11min on Linux and ~45min on Windows, by far the slowest test category, invalidating the point of unit tests giving fast feedback.

For example, test_append_with_defragmentation is a hypothesis test exercising multiple functions with no clear emphasis on what specific behaviour it's checking, so it's not a unit test. It also takes 9-13min to run on non-in-memory storage, which makes it very expensive to run against more storage types. It should either be rewritten to test a specific thing or moved to the stress folder.

@qc00 qc00 added the refactor label Nov 8, 2023
@poodlewars poodlewars closed this as not planned Won't fix, can't repro, duplicate, stale Apr 11, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

No branches or pull requests

2 participants