Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix RAILS_ROOT definitions #4

Closed
carbonin opened this issue Nov 10, 2016 · 3 comments
Closed

Fix RAILS_ROOT definitions #4

carbonin opened this issue Nov 10, 2016 · 3 comments
Labels

Comments

@carbonin
Copy link
Member

Many of these are relying on the old location of this code within the manageiq directory structure.

12:03:07:~/Source/manageiq-gems-pending/lib/gems/pending (master)$ git grep RAILS_ROOT
appliance_console.rb:10:RAILS_ROOT = [
appliance_console.rb:16:ENV['BUNDLE_GEMFILE'] ||= RAILS_ROOT.join("Gemfile").to_s
appliance_console.rb:50:VERSION_FILE  = RAILS_ROOT.join("VERSION")
appliance_console.rb:51:LOGFILE       = RAILS_ROOT.join("log", "appliance_console.log")
appliance_console.rb:59:MiqPassword.key_root = "#{RAILS_ROOT}/certs"
appliance_console/database_configuration.rb:11:RAILS_ROOT ||= Pathname.new(__dir__).join("../../..")
appliance_console/database_configuration.rb:20:    DB_YML      = RAILS_ROOT.join("config/database.yml")
appliance_console/database_configuration.rb:21:    DB_YML_TMPL = RAILS_ROOT.join("config/database.pg.yml")
appliance_console/external_auth_options.rb:7:RAILS_ROOT ||= Pathname.new(__dir__).join("../../..")
appliance_console/external_auth_options.rb:11:    # VMDB_YML      = RAILS_ROOT.join("config/vmdb.yml.db")
appliance_console/external_auth_options.rb:12:    # VMDB_YML_TMPL = RAILS_ROOT.join("config/vmdb.tmpl.yml")
appliance_console/internal_database_configuration.rb:7:RAILS_ROOT ||= Pathname.new(__dir__).join("../../../")
appliance_console/key_configuration.rb:6:RAILS_ROOT ||= Pathname.new(__dir__).join("../../..")
appliance_console/key_configuration.rb:10:  CERT_DIR = "#{RAILS_ROOT}/certs"
appliance_console/logging.rb:4:RAILS_ROOT ||= Pathname.new(__dir__).join("../../..")
appliance_console/logging.rb:8:    LOGFILE = File.join(RAILS_ROOT, "log", "appliance_console.log")
appliance_console/utilities.rb:14:      result = AwesomeSpawn.run("rake #{task}", :chdir => RAILS_ROOT, :params => params)
appliance_console/utilities.rb:22:                                :chdir  => RAILS_ROOT
appliance_console/utilities.rb:40:        :chdir  => RAILS_ROOT
postgres_ha_admin/failover_monitor.rb:10:    RAILS_ROOT = [
postgres_ha_admin/failover_monitor.rb:76:                       :chdir  => RAILS_ROOT,
util/postgres_admin.rb:5:RAILS_ROOT ||= Pathname.new(__dir__).join("../../../")
util/postgres_admin.rb:42:    RAILS_ROOT.join("certs")
@Fryguy
Copy link
Member

Fryguy commented Oct 24, 2017

@carbonin What should we do with this now that things have been split out?

@carbonin
Copy link
Member Author

It's no better now, we should probably still do something about it. Also seems related to (if not a duplicate of) ManageIQ/manageiq-appliance_console#8

@miq-bot miq-bot added the stale label Apr 30, 2018
@miq-bot
Copy link
Member

miq-bot commented Apr 30, 2018

This issue has been automatically marked as stale because it has not been updated for at least 6 months.

If you can still reproduce this issue on the current release or on master, please reply with all of the information you have about it in order to keep the issue open.

Thank you for all your contributions!

carbonin added a commit to carbonin/manageiq-gems-pending that referenced this issue Apr 30, 2018
The last caller of PostgresAdmin.certificate_location
was removed in ManageIQ/manageiq-appliance_console#22

Fixes ManageIQ#4
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

No branches or pull requests

3 participants