You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
seems that the URL generated there for breadrumb is wrong -- it contains db that comes from get_rec_cls and that returns a class.
some of the show_timeline methods call find_by_id_filtered that should be probably called everywhere instead
there are a bunch of alianses (such as :image_timeline,, some are used from toolbars)
there's extra code to deal with @explorer being true
warning: if inside a module A you use:
included do
include Mixins::MoreShowMixins
end
and then try to redefine a method from MixingsMoreShowMixins, you'll fail as the method from the included mixin will get called, not the one in module A.
When done, look at app/controllers/container_controller.rb it also has it's implementation of the methods from MoreShowMixins but slightly differently arranged.
The text was updated successfully, but these errors were encountered:
martinpovolny
changed the title
Use MoreShowMixins in app/controllers/vm_common.rb
Deduplicate app/controllers/vm_common.rb by using MoreShowMixins
Feb 14, 2017
@martinpovolny is this still a valid issue? If yes, lease remove the stale label. If not can you close.
If there's no update by next week, I'll be closing this issue.
For some of the methods the code is the same.
I see a problem with 'show_timeline':
db
that comes fromget_rec_cls
and that returns a class.show_timeline
methods callfind_by_id_filtered
that should be probably called everywhere instead:image_timeline
,, some are used from toolbars)@explorer
being truewarning: if inside a
module A
you use:and then try to redefine a method from
MixingsMoreShowMixins
, you'll fail as the method from the included mixin will get called, not the one in moduleA
.When done, look at
app/controllers/container_controller.rb
it also has it's implementation of the methods fromMoreShowMixins
but slightly differently arranged.The text was updated successfully, but these errors were encountered: