New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Separate build and push actions into individual functions #17

Open

anaPerezGhiglia opened this issue Mar 13, 2023 · 1 comment

Labels

Member

anaPerezGhiglia commented Mar 13, 2023

Define separate build and push functions so

we can receive and pass extra parameters to the docker build and docker push commands (i.e.: --build-arg)
the user can override only one of them but still leverage of the definition of dockerBuildAndPush

Having this will help fixing #2 - the user will be able to invoke only build function for non "pushable" branches if desired

The text was updated successfully, but these errors were encountered:

Contributor

ysbaddaden commented Mar 14, 2023 •

edited

Let's note that #16 implements the -o option to pass build options such as --build-arg to the docker build command.

But being able to build & push independently would be nice.

ysbaddaden added the enhancement label

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment